Repository navigation
ci: test on macOS and Windows with Python 3.14 - #295
Merged
Merged
Conversation
Run the test suite on macos-latest (arm64, which installs the Metal backend) and windows-latest for the newest Python only, without fail-fast, and print whether Metal can run on the macOS runner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ult to Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI ran only on
ubuntu-latest, although the package claims to run on any operating system, and the Metal backend (#290) was never installed or imported in CI.macos-latest(arm64, sopyobjc-framework-Metalis installed) andwindows-latestto the test matrix, for Python 3.14 only. Version-specific failures already show up on the four Linux jobs.fail-fast: false, so one OS failing does not cancel the others.bashon every OS (Git Bash on Windows) so the existing commands work unchanged.runtime.unavailable(). On the standard runner it reportsthe Metal executor needs an Apple GPU (Apple silicon)(the runner has an Apple Paravirtual device), sotest/integration/test_metal_sampler.pystill skips there.Fixes that Windows needed:
tesseract-decoderhas no Windows wheels; the dev dependency is now limited tosys_platform != 'win32'(uv.lock updated).test_skills.pyalready skips decoders it cannot import.test/unit/test_dev_cli.pyskips on Windows: thetsim-devCLI importsfcntland is POSIX-only.test_skills.pyreads the skill's Markdown as UTF-8; Windows defaulted to cp1252 and failed on non-ASCII characters.Coverage upload is unchanged (Linux, 3.12). No user-visible change, so no changelog entry.
🤖 Generated with Claude Code