Qblox qmi driver - #215
Open
heevasti wants to merge 7 commits into
Open
Qblox qmi driver#215heevasti wants to merge 7 commits into
heevasti wants to merge 7 commits into
Conversation
added 7 commits
May 28, 2026 17:58
…rted editing unit-tests.
bvanommen
requested changes
Sep 18, 2026
| EXT_TRIGGERS_IN_CLUSTER = 15 | ||
| # Module configuration constants: | ||
| # AO_IN_MODULE: Analog output channels in modules with value range -1V...+1V. | ||
| # AI_IN_MODULE: Analog output channels in modules with value range -1V...+1V. |
Collaborator
There was a problem hiding this comment.
input channels presumeably
| # Add type handles as callables | ||
| for type_handle, value in self.cluster._type_handle.__dict__.items(): | ||
| if type_handle.startswith("_is"): | ||
| # As 'value' gets overridden in memory for the lambda function, do like this: |
| idn = self.cluster._get_idn() | ||
| _, model, _, _ = idn.split(",") | ||
| self._modules = {"0": _QbloxModule(model, self.cluster_funcs)} | ||
| for k, v in self.cluster._mod_handles.items(): |
Collaborator
There was a problem hiding this comment.
code would be a bit more readable if these keys and values have a bit more descriptive names
Collaborator
There was a problem hiding this comment.
I guess the v's are modules?
| if str(module) == module_type: | ||
| # Just double check module type before returning | ||
| if ( | ||
| module_type == "QCM" |
Collaborator
There was a problem hiding this comment.
if these two are on the same line it looks much better
| self.cluster._slot_reset() | ||
|
|
||
| @rpc_method | ||
| def get_module(self, module_type: str, slot_no: int | None = None) -> NativeCluster | _QbloxModule: |
Collaborator
There was a problem hiding this comment.
I guess it might be fair enough, but if you have multiple of the same module and you specify the module name, it's not clear which one you're gonna get. Maybe ideally you warn the user (or refuse) when you know there are duplicate modules and they didn't specify the slot.
| for sequencer in range(SEQUENCERS_IN_MODULE[module_type]): | ||
| try: | ||
| sequencer_config = module_func_refs["_get_sequencer_config"](sequencer) | ||
| if channel_type in [0, 1] and AI_IN_MODULE[module_type] > 0: |
Collaborator
There was a problem hiding this comment.
magical constants, ideally we replace
| for channel in sequencer_channel_map[1]: | ||
| channels[f"adc{channel}_acq_Q{sequencer}"] = sequencer_config["awg"] | ||
|
|
||
| if channel_type in [0, 2] and AO_IN_MODULE[module_type] > 0: |
| for channel in sequencer_channel_map[1]: | ||
| channels[f"dac{channel}_Q{sequencer}"] = sequencer_config["awg"] # TODO: Is this always valid? | ||
|
|
||
| if channel_type in [0, 3] and DIGITAL_MARKERS_IN_MODULE[module_type] > 0: |
| invert: Any | ||
|
|
||
|
|
||
| class Qblox_QcodesCluster(Qblox_ClusterBase): |
Collaborator
There was a problem hiding this comment.
what is the difference between this class and Qblox_NativeCluster?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a QMI driver for Qblox Cluster series device.
The driver contains only base functions to control the cluster, and trigger channels, and receive system info and module | function reference objects.