Repository navigation
Conversation
mortondev
force-pushed
the
feat/portal-design-v2-phase2-sections
branch
from
October 30, 2026 20:19
febdfe5 to
51d9268
Compare
mortondev
force-pushed
the
feat/portal-design-v2-phase2-sections
branch
from
October 30, 2026 20:40
51d9268 to
d2e991b
Compare
On the design engine the feedback page reads its welcome message from the design, where it can be switched off, rather than from the portal settings. A converted workspace keeps its text, since the converter carries the welcome card over. Appearance edits it under Sections with the editor the settings page used, now a component of its own, and the preview shows it as it changes. The Navigation tab no longer offers the legacy welcome card on the design engine, so there is one place to edit it.
A design chooses a band for the top of the feedback page: none, a tint of the subtle accent, a fade from it into the page, or the accent itself. Its look comes from band tokens and data-qb-band, with its text solved to 4.5:1 on the band. A headline and subtitle sit in it, in the visitor's language, falling back to its base language, then English, then any. A plain band with no headline adds nothing to the page, so a converted design keeps today's markup. Appearance edits both under Sections, and the preview shows a draft headline as it changes. solveContrast moves into contrast.ts, which the component tokens now share with the resolver. Computed styles on 16 portal pages are unchanged with the engine off and on.
Presets are design looks: Classic (today's portal), Studio, Editorial, Calm, Technical, Midnight, Paper and Bold. Each sets the mode, colours, fonts, corners and layout, and each passes every pair the portal paints in light and dark. Applying one changes the draft's look and leaves its pages, menu, words and logo alone. Brand opens with Start from a preset, a gallery that draws each look: its page and band colours, heading face and card style.
The admin consistency check wants every settings switch drawn by SettingRow, and the feed page test's preview context mock gains the headline hook the band reads.
mortondev
force-pushed
the
feat/portal-design-v2-phase2-sections
branch
from
October 30, 2026 21:16
d2e991b to
8937b48
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fifth of the stack that builds a new design engine for the portal. This one moves the feedback page's welcome message into the design, adds a top band with a headline, and adds eight presets to start from. Behind the
portalDesignV2Labs switch; with it off, nothing changes.The welcome message
On the design engine, the feedback page reads its welcome message from the design, where it can be switched off, rather than from the portal settings. A converted workspace keeps its text, since the converter carries the welcome card over.
Appearance edits it under Sections, with the editor the settings page used, now a component of its own, and the preview shows it as it changes. On the design engine the Navigation tab no longer offers the legacy welcome card, so there is one place to edit it.
The top band and headline
data-qb-band, with the band's text solved to 4.5:1 on the band.solveContrastmoves intocontrast.ts, which the component tokens now share with the resolver.Presets
Eight starting looks: Classic (today's portal), Studio, Editorial, Calm, Technical, Midnight, Paper and Bold.
Screens
Checked in a real browser against the production build: the preset gallery, and the Studio preset with a headline in the preview. No console errors.
Verification