Repository navigation
Conversation
mortondev
changed the title
mortondev
force-pushed
the
feat/portal-design-v2-phase2-header
branch
from
October 30, 2026 20:19
b9c26d0 to
72f30ad
Compare
mortondev
force-pushed
the
feat/portal-design-v2-phase2-header
branch
from
October 30, 2026 20:40
72f30ad to
128825b
Compare
A design can put the portal menu beside the logo (inline) or centre the logo and menu (centred). Below md an inline header folds back to two rows, so the menu always has room. Stacked keeps today's markup exactly, so the legacy theme and a converted design render as before; the other two are marked data-qb-section=header. In the admin preview the header follows the draft's layout over the saved one. The Appearance preview now lays the portal out at desktop width and scales it to fit, so desktop layouts such as an inline header and the filter panel show as visitors see them. The legacy page's preview is unchanged. Computed styles on 16 portal pages are unchanged with the engine off and on.
mortondev
force-pushed
the
feat/portal-design-v2-phase2-header
branch
from
October 30, 2026 21:17
128825b to
56f7331
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sixth of the stack that builds a new design engine for the portal. This one adds inline and centred header layouts, and lets the Appearance preview show desktop layouts as visitors see them. Behind the
portalDesignV2Labs switch; with it off, nothing changes.Header layouts
mdan inline header folds back to two rows, so the menu always has room.data-qb-section="header".A desktop-width preview
The Appearance preview frame is narrower than a desktop browser, so desktop layouts such as an inline header and the filter panel never showed there. The desktop preview now lays the portal out at 1280px and scales it to fit. The legacy settings page's preview is unchanged.
Verification
md; the draft layout winning in the preview.