Repository navigation
Conversation
On the design engine the feedback page sorts by the design's default (trending, top or new) until the visitor picks one: the loader, the feed, its loading state and the container all read it, and clearing a search returns to it. A legacy portal sorts by trending as before. Appearance sets it under Sections › Feed, and the preview loads with the draft's sort. Review and publish names the page's changes as the controls do: the headline, the subtitle, the welcome message and its text.
The header, the band, the welcome message, the feed and the filter panel are marked with data-qb-section. While a design is previewed, the frame outlines the innermost section under the pointer and, on a click that is not on one of its links, buttons or fields, tells Appearance which section it is. Appearance then opens Sections at that section's controls. The legacy settings preview and the live portal are untouched.
The logo belongs to the workspace: Settings › General sets it for the portal, the admin and email, and the portal header reads it there. Brand shows the current logo with a link to change it, so there is one place to edit it rather than a second copy in the design.
The sort tiles used three icons, and since Appearance is part of the Settings › Portal route, every visit to that page loaded their chunks. They are drawn like the other tiles: bars rising for trending, falling for top, and a dot on the newest.
mortondev
changed the title
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seventh of the stack that builds a new design engine for the portal, and the last of phase 2. It adds the feed's default sort to the design, lets an admin click a section in the Appearance preview to edit it, and shows the workspace logo in Brand. Behind the
portalDesignV2Labs switch; with it off, nothing changes.Default sort
On the design engine the feedback page sorts by the design's default (trending, top or new) until the visitor picks one. The loader, the feed, its loading state and the container all read it, and clearing a search returns to it. A legacy portal sorts by trending as before. Appearance sets it under Sections › Feed, and the preview loads with the draft's sort.
Click a section to edit it
The header, the band, the welcome message, the feed and the filter panel are marked with
data-qb-section. While a design is previewed, the frame outlines the innermost section under the pointer. A click that is not on one of the section's links, buttons or fields tells Appearance which section it is, and Appearance opens Sections at that section's controls. The code lives in the preview frame's design channel, which loads only in the preview, so the live portal and the legacy settings preview are untouched.The logo
The logo belongs to the workspace: Settings › General sets it for the portal, the admin and email, and the portal header reads it there. Brand shows the current logo with a link to change it, so there is one place to edit it.
Verification