Repository navigation
Conversation
An agent edits the portal design draft and asks a person to publish it. publish_portal_design files an approval listing the draft's changes, named as Appearance names them; nothing goes live until a person who may edit branding approves it, and then exactly that draft is published. A draft that moved after the request is refused. Asking again for the same draft returns the waiting request. Home edits the draft directly, since visitors never see a draft, and files a publish only when asked. The design tools are offered only while the portal uses the design engine.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ninth of the stack that builds a new design engine for the portal. An agent can edit the portal design draft and ask a person to publish it; only a person's approval publishes. Behind the
portalDesignV2Labs switch, and the design tools are offered only while the portal uses the design engine.Publishing is a request
publish_portal_designnever publishes. It files an approval listing the draft's changes, each named as Appearance names it ("Accent", "Density"), and returns the approvals link. A person who may edit branding approves it on the approvals page, and exactly the draft they were shown goes live, recorded as theirs. If the draft changed after the request, the approval is refused withDRAFT_CHANGEDand nothing is published; ask again. Asking again for the same draft returns the waiting request. The key that asked can never approve its own request.The request takes no note: everything an approval shows is written by the server from the draft, never by the agent.
Home
Home edits the draft directly, since visitors never see a draft, and files a publish only when asked. Its prompt names the exception to "every change is a proposal". If the portal still uses the legacy theme, the design tools say so and Home points to Settings › Portal.
Approvals
A design publish shows its changes field by field, under Branding, and refreshes the design editor once approved. What a request shows (the diff on the page, and the title, summary and changes followers read) now lives in one module,
approval-content.ts, for settings requests and design publishes alike.Verification
settings.branding, and the dependency graph the assistant → design edge.