Repository navigation
Conversation
A workspace created now has portalDesignV2 on, so its portal renders through the design document and Settings › Portal opens on Appearance. Existing workspaces keep their theme until someone turns the engine on in Labs.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The twelfth of the stack that builds a new design engine for the portal, and the last of phase 3. New workspaces start on the design engine.
A workspace created now has
portalDesignV2on, so its portal renders through the design document and Settings › Portal opens on Appearance. Existing workspaces keep their theme until someone turns the engine on in Labs; nothing changes for them on upgrade. The plan makes it the default for everyone one release later.Kept as its own PR so it can be held back while the rest of the stack lands.
Verification
The flag tests now check that the default stays off and that new workspaces start with it on. The settings and onboarding suites pass.