Repository navigation
Conversation
On the design engine the header's menu comes from the design, but the Navigation tab still edited the legacy menu, so its changes never showed. The menu now lives in Sections, under the header, and writes the draft. - While Home is on: Home in the menu, and its tab's name. - The pages and links in order, each shown or hidden and renamed, with links added and removed, in the same editor as before. Feedback can be hidden too, as the design engine allows. - The rows reach the draft once every link in them is whole and, with Home off, they show a page to start on; until then a note says what is missing. A menu changed elsewhere, such as by a discard, replaces them. - Review and publish names the menu and Home's tab name, and counts what the menu shows. The Portal settings page on the design engine is Appearance alone; its Navigation tab is gone.
mortondev
force-pushed
the
feat/portal-design-v2-phase4-menu
branch
from
October 31, 2026 04:36
9e1fbb7 to
5a66bf2
Compare
Appearance now imports the portal header's menu module for the menu editor, which moves a chunk boundary the post page loads across: 0.2 KB more script there, just over a ceiling it sat at.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fifteenth of the stack that builds a new design engine for the portal, and the third of phase 4. On the design engine the header's menu comes from the design, but the Navigation tab still edited the legacy menu, so its changes never showed. The menu now lives in Appearance and writes the design draft. Behind the
portalDesignV2Labs switch; with it off, nothing changes.The menu in Sections
Under the header's layout and menu style:
Review and publish
The menu and Home's tab name have names, and the menu reads as how many items it shows.
Portal settings
On the design engine the Portal settings page is Appearance alone; the Navigation tab is gone. The legacy theme keeps its page as it was, its navigation editor included.
Performance
Appearance imports the portal header's menu module for the editor, which moves a chunk boundary the post page loads across: 0.2 KB more script there, just over the ceiling it sat at, so
ui:portal-post-loadtakes its reading (459.1 KB). Request counts hold.Verification
/feedback. No page errors.