[mortondev]

The sixteenth of the stack that builds a new design engine for the portal, and the fourth of phase 4. A new workspace's portal starts on Home; an established workspace's root never changes on upgrade. Behind the portalDesignV2 flag, which new workspaces start with.

What setup does

When a new workspace finishes the goal step, setup publishes the design it starts with:

• its branding converted, the same conversion an established workspace's branding gets on read;
• Home on, laid out from the pages its goals turned on (starterHomeBlocks): Welcome, Share an idea with Status, Top ideas with Latest updates, the roadmap and help topics, each only when its page exists.

It is the first published version, from setup (source: 'conversion') with no author, so History shows where it came from.

When it does not

• An established workspace: its root stays as it is, Home off, until someone turns Home on in Appearance.
• The design engine off, or custom CSS that a switch would have to carry over: the workspace stays on its theme, as it would today.
• A workspace that already has a design, published or drafted: it keeps it. Saving the goals again does not lay Home out a second time.
• PORTAL_DESIGN_ENGINE=legacy still keeps every portal on its theme, published design or not.

Also

The two setup tests that stood in for the settings helpers now pass the real ones through, since setup reads the portal config to lay Home out.

Verification

• New tests, each checked by breaking the code it covers: the starting design is published as version 1 with no author, and a workspace with a design is left alone; a new workspace's portal starts on Home with the blocks its goals call for (no Status block without the Status goal) and keeps that layout when the goals are saved again; an established workspace with the design engine on, and a new one with it off, get no design.
• The onboarding, settings, design and server suites pass. Running many onboarding DB suites in parallel on one local database can deadlock on the workspace slug; that happens the same way without this change.

[mortondev]

Condensed into #879. The stack is now five PRs, #878 to #882; this branch is kept as it was.