Repository navigation
Conversation
The status change, new comment, mention and linked-feedback emails said "your feedback" and "View Feedback". They now say the portal's word: "Your suggestion is now Planned!", "New comment on your idea", "View feature request", and the status subject too. Idea when none is chosen. The hook context reads the word as the portal does, from the workspace settings' design, once per event, and the post subscribers' and mention targets carry it to the senders. An email still goes out, saying idea, if the design cannot be read.
mortondev
force-pushed
the
feat/portal-design-v2-phase4-email-words
branch
from
October 31, 2026 05:22
9c9ac3b to
cbf854e
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eighteenth of the stack that builds a new design engine for the portal, and the sixth of phase 4. The emails a visitor gets about what they posted name it in the portal's word, as the portal does since the PR below.
What changes
"Your feedback" stays in the linked-feedback email, where it means the person's own message rather than the post. Idea is the word when none is chosen, so a workspace that never chose one reads "Your idea is now Planned!". The emails are English only, as before.
How the word gets there
PORTAL_DESIGN_ENGINE=legacyall give idea. If the design cannot be read, the email still goes out, saying idea, with a warning in the log.sendStatusChangeEmail,sendNewCommentEmailandsendPostMentionEmail.sendFeedbackLinkedEmailtakes it too.@quackback/email,post-word.tsholds the nouns, andstatusChangeSubject()builds the subject.Also in the PR below
A follow-up commit there words the notification parity check as the admin does: a stored notification row says "a post", and the portal's bell words it again in the portal's word.
Verification
New tests, each checked by breaking the code it covers: the four templates and the status subject in the chosen word and by default, with no "feedback" left in the status and comment emails; the handler passes the config's word to each sender; the hook context carries the published word and says idea, with a warning, when the design cannot be read. The server and email suites pass.