fix: preserve legacy execution reports and dry-run mode consistency - #320
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy deployments without a strategy revision could fail after a completed cycle, then fail again while recording the exception, losing the final report and obscuring the original error. Skip the optional execution receipt only for an explicit
legacy_unattestedrelease withoutstrategy_release; invalid attested revisions remain rejected.The real cycle regression also exposed a dry-run override retaining
execution_environment=live. Keep the requested dry-run flag and execution environment consistent while disabling live trading for that request.Validation: reproduced the legacy receipt and dry-run failures before patching; 419 tests pass, including real report construction and cycle finalization for submitted, blocked and exception outcomes in both modes. Ruff, lock and diff checks pass. No credentials, strategy parameters, order limits or schedules are changed.