fix: localize concise runtime failure notifications - #321
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chinese locale variants could fall back to English, and startup failure notifications contained deployment details or long provider errors. Runtime failures now use a five-line localized summary with the strategy name, relevant platform context, outcome, and next action.
Reuse the existing QPK locale normalizer and each platform's translation catalog. Preserve HTTP status, execution-report fields, account routing, delivery behavior, and all trading/risk gates. Fallback logs use stable reason codes without provider exception bodies.
Validation: 56 tests across notification and request-handling tests passed; Ruff passed. Full protected CI remains required before merge. No live execution endpoint was invoked.
Firstrade keeps the existing notification_attempted response meaning, and logs a localized delivery failure when the sender returns false.