fix: explain sanitized runtime configuration failures - #467
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SG failed during runtime configuration because a paper-only command producer was enabled together with live mode. The handler reduced both the log and Telegram alert to RuntimeError, hiding the actionable cause.
Add localized failure stages and a fixed, allowlisted explanation for the existing paper/live configuration rejection. Persist the same safe phase/reason in reports and structured logs. Unknown provider errors remain sanitized; broker execution and all existing safety gates are unchanged.
Validation: new regressions fail on the original handler and pass with the patch; 491 tests and 60 subtests pass (1 skipped), Ruff and bounded deployment workflow tests pass. The initial full run picked up existing local lifecycle history; a dedicated empty test directory resolves that environmental failure without changing production logic or the original assertion. An offline preflight using the deployed configuration reproduces the conflict, and changing only its paper-only opt-in to false passes configuration assembly with zero network calls. The production opt-in correction is an operational configuration change, separate from this code patch.