Conversation
|
Really looking forward to this! Hope it can be merged soon… just want to say that there's lots of support and excitement for this, @QuantumBadger! :) See also https://old.reddit.com/r/RedReader/comments/1t3jmej/why_does_the_inbox_behave_so_inefficiently/ |
Owner
|
Thanks for the contribution @folkemat. I had a look through this PR and the main issue is that there's no visual indicator for whether a message is read or not, so if someone taps a message then nothing will appear to have happened. Rather than merge this, I've gone ahead and implemented a larger set of improvements to the inbox, which show the read status of each post and also add a "mark read" button: This is present in Alpha 372: Let me know if you encounter any issues! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR implements the “read_message” function of the Reddit API, which allows to mark individual messages as read.
A message that is tapped on in the inbox now gets individually marked as read.
I have disabled this option by default, but maybe it's not a big stretch to enable it by default.
Closes #554