FixTaylorCluster for non-square (finite) Hamiltonians - #511
Open
VictorVanthilt wants to merge 5 commits into
Open
FixTaylorCluster for non-square (finite) Hamiltonians#511VictorVanthilt wants to merge 5 commits into
TaylorCluster for non-square (finite) Hamiltonians#511VictorVanthilt wants to merge 5 commits into
Conversation
lkdvos
reviewed
Aug 12, 2026
lkdvos
reviewed
Aug 12, 2026
Comment on lines
+166
to
+167
| (I[1] in row_threelevel_linds || I[4] in col_threelevel_linds) && delete!(slice, I) | ||
| end |
Member
There was a problem hiding this comment.
can we check the properties that define the threelevel_linds instead, mapping it to a cartesian index first?
Member
Author
There was a problem hiding this comment.
I'm not quite sure I fully understood your comment but I changed the code to first make the set of CartesianIndices that fall in a to-be-deleted row/column. I then loop over the intersection of this set and the nonzero_keys. This avoids a lot of misses in the "for key in nonzero_keys" loop.
lmk if this is not what you meant
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
Author
|
I don't understand this test failure, I can't see what failed from the logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TaylorCluster algorithm's "loopback" algorithm involves removing the rows and columns that are labled by level-labels only containing 1's and "3"'s. Currently the rows and columns were removed using the right-virtualsize of the Hamiltonian as the "3" level.
To be correct for non-square Hamiltonians, we need to remove the columns with a "3" level based on the right-virtualsize and the rows based on the left-virtual size. This PR implements this.
Checklist
julia --project=test test/runtests.jl, or the relevant subset)docs/src/)[Unreleased]indocs/src/changelog.md, if this PR is user-facing (new feature, behavior change, bug fix, deprecation, or removal)