Repository navigation
fix(memory): stop crashing when Vision rejects a screenshot - #21
Merged
Merged
Conversation
On failure, Vision calls the request's completion handler with the error and also throws from perform, so TextRecognizer resumed its continuation twice and the app aborted. Automatic Memory then retried the same image after each relaunch, so Menew quit every few minutes. The continuation is now resumed once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menew 1.100.0 quits by itself every ~5 minutes on macOS 27 (3 crash reports here:
EXC_BREAKPOINTinCheckedContinuation.resumeon a background thread).Cause: when Vision can't read an image, it calls the
VNRecognizeTextRequestcompletion handler with the error and throws fromperform, soTextRecognizer.recognizeresumed its continuation twice (SWIFT TASK CONTINUATION MISUSE). Automatic Memory retried the same screenshot after every relaunch.Fix:
ResumeOnceresumes the continuation only once. New test with a 1×1 image reproduces the exact crash on the old code (signal 5, "tried to resume its continuation more than once") and passes now. 92 tests pass. CHANGELOG: 1.100.1.🤖 Generated with Claude Code