Repository navigation
Hide duplicate bootstrap echo from terminal history - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At shell startup, the real OpenSSH fixture emitted two exact copies of Threadline's bootstrap line. The filter removed the first and left the generated script in raw terminal history.
Allow at most two exact bootstrap echoes before the existing lifecycle cancellation or bootstrap timeout. Ordinary wrapper input still allows one exact echo; raw input and replies use no echo expectation. The byte matching and fail-open handling remain unchanged.
Validation:
./gradlew test lint assembleDebugpassed.fixtures/openssh/test-android-structured.shpassed all three real-SSH Android tests on API 35, including bootstrap and command echo suppression, direct raw input followed by a structured command, replies, and encrypted-key authentication.Refs #66. Signed owner-device acceptance remains open on that issue.