Repository navigation
Checkpoint completed transcript turns during live sessions - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #49.
Validation
./gradlew test lint assembleDebug assembleDebugAndroidTest: passed. After the fixture test correction, the exact CI command./gradlew --no-daemon test lint assembleDebug assembleReleasealso passed with 110 app JVM tests. The three opt-in JVM fixture cases were skipped in the routine run../scripts/verify-release-shrinker-contracts.sh: passed.connectedDebugAndroidTest: all five Room retention/reopen and History UI tests passed on API 35../fixtures/openssh/test-android-transcript-process-death.sh: passed both durable and ephemeral cases against real OpenSSH. Each preparation was still connected with an unfinished command when force-stopped. Fresh processes reopened disconnected with only the completed durable turn, or no ephemeral history../fixtures/openssh/test-android-structured.sh: all three production SSH tests passed, covering persistent shell state, replies, encrypted key reload, raw terminal behavior, interruption, and bounded output.git diff --check: passed.The first CI run hit a two-second timeout in the ephemeral unit test. The archive tests now wait for recorded fake client sends before injecting server lifecycle markers, and allow five seconds for those waits under CI build load. This follow-up changes only tests. The missing CI failure reports are tracked separately in #72.
Limits
Only completed turns are checkpointed while connected. A crash can lose an unfinished command and a database write still in flight. No live SSH connection or shell state is resumed after process death. Signed phone acceptance remains separate.