Skip to content

Fix v0.9.26 hiroba w2026 64 hiroba #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kanon-yoneji merged 2 commits into from
Oct 26, 2026
Merged

Fix v0.9.26 hiroba w2026 64 hiroba #1949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc4502b
fix: update nginx configuration for SSL and gzip settings
ryoya-hayase Oct 26, 2026
324f3aa
Merge pull request #1323 from ryoya-hayase/fix/0.9.26_hiroba_nginx_gzip
kanon-yoneji Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions nginx/weko.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ server {
}

server {
listen 443;
ssl on;
listen 443 ssl;
ssl_protocols TLSv1.3 TLSv1.2;
ssl_certificate /etc/nginx/server.crt;
ssl_certificate_key /etc/nginx/server.key;
Expand Down Expand Up @@ -342,7 +341,7 @@ server {

gzip on;
gzip_disable "msie6";
gzip_http_version 1.1;
gzip_http_version 1.0; # 前段のプロキシは既定で HTTP/1.0 で転送してくる

@sourcery-ai sourcery-ai Bot Oct 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · HTTP/1.0 clients gain compression oracle

When an attacker can induce an HTTP/1.0 proxied request whose response contains both a secret and attacker-controlled reflected data, nginx compresses the response, making its TLS ciphertext length vary with guesses about the secret; an attacker can use those lengths as a BREACH-style oracle to recover it.

Exclude sensitive responses from compression or ensure secret-bearing responses do not reflect attacker-controlled data.

Prompt for AI agents 
In `nginx/weko.conf` at line 344:

**HTTP/1.0 clients gain compression oracle**

When an attacker can induce an HTTP/1.0 proxied request whose response contains both a secret and attacker-controlled reflected data, nginx compresses the response, making its TLS ciphertext length vary with guesses about the secret; an attacker can use those lengths as a BREACH-style oracle to recover it.

Exclude sensitive responses from compression or ensure secret-bearing responses do not reflect attacker-controlled data.

gzip_comp_level 5; # or anything between 4-6
gzip_min_length 100;
gzip_proxied any;
Expand All @@ -352,7 +351,6 @@ server {
application/json
application/ld+json
application/manifest+json
application/octet-stream
application/rss+xml
application/vnd.geo+json
application/vnd.ms-fontobject
Expand All @@ -368,7 +366,6 @@ server {
image/x-icon
text/cache-manifest
text/css
text/html
text/javascript
text/plain
text/vcard
Expand Down
Loading