Skip to content

Develop v2.1.0 #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ooka-Masashi merged 2 commits into from
Oct 28, 2026
Merged

Develop v2.1.0 #1952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3809284
Enable the access rights modification feature(#63818)
ivis-miyachi Oct 28, 2026
a7f7da9
Merge pull request #1951 from RCOSDP/fix/issue63818_note5
Ooka-Masashi Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/instance.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,3 +889,5 @@ WEKO_RECORDS_UI_S3_TRANSFER_USE_THREADS = True
WEKO_RECORDS_UI_S3_TRANSFER_MAX_CONCURRENCY = 10
"""Number of threads for multipart upload/download for S3 compatible service transfer. Default is 10."""

WEKO_SEARCH_FIX_ACCESSRIGHTS = True

@sourcery-ai sourcery-ai Bot Oct 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Invalid embargo dates block saves

When a record being saved has a file dateValue shaped like YYYY-MM-DD but not representing a valid calendar date, update_embargo_rights accepts any date matching YYYY-MM-DD in its regex, then datetime.strptime raises ValueError for an impossible calendar date such as 2026-02-30. Since json_loader calls this function while saving records, the save fails.

Parse dates defensively and treat invalid calendar values as missing rather than raising.

Prompt for AI agents 
In `scripts/instance.cfg` at line 892:

**Invalid embargo dates block saves**

When a record being saved has a file `dateValue` shaped like `YYYY-MM-DD` but not representing a valid calendar date, `update_embargo_rights` accepts any date matching `YYYY-MM-DD` in its regex, then `datetime.strptime` raises `ValueError` for an impossible calendar date such as `2026-02-30`. Since `json_loader` calls this function while saving records, the save fails.

Parse dates defensively and treat invalid calendar values as missing rather than raising.

"""Fix access rights for search indexes. True if fixing access rights."""
Loading