feat: add rdma_reject, rdma_get_devices and address getters - #116
feat: add rdma_reject, rdma_get_devices and address getters#116dragonJACson wants to merge 2 commits into
Conversation
91c5661 to
a35f549
Compare
There was a problem hiding this comment.
Code Review
This pull request adds support for rejecting connections, querying RDMA devices, and retrieving local and remote ports and socket addresses from an Identifier. The review feedback highlights several critical compilation issues, including calls to an undefined helper function port_from_raw_addr in tests, and incorrect pointer usage (self.cm_id.as_ref() instead of self.cm_id.as_ptr()) when calling FFI functions. Additionally, the get_devices function needs to be updated to correctly handle cases where no RDMA devices are present on the system without returning an error.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
36de44f to
d10e5f0
Compare
There was a problem hiding this comment.
Pull request overview
This PR expands the RDMA CM wrapper API by adding connection rejection support, device enumeration via RDMA CM, and convenient accessors for local/peer addresses and ports, while reusing the existing global DeviceContext cache.
Changes:
- Add
Identifier::reject()wrappingrdma_reject, with a dedicatedRejectError. - Add
get_devices()wrappingrdma_get_devicesand integrating results with the globalDeviceContextcache. - Add
Identifiergetters for local/peerSocketAddrand for src/dst ports; update/add tests to cover new helpers and improve robustness.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d10e5f0 to
e1d8c52
Compare
e1d8c52 to
1edec9c
Compare
1edec9c to
faabe98
Compare
No description provided.