Skip to content

Use profile scopes for portal trigger variables - #86

Merged
yoshifuminakamura merged 1 commit into
developfrom
feature/portal-profile-scope-trigger-vars
Aug 6, 2026
Merged

Use profile scopes for portal trigger variables#86
yoshifuminakamura merged 1 commit into
developfrom
feature/portal-profile-scope-trigger-vars

Conversation

@yoshifuminakamura

Copy link
Copy Markdown
Collaborator

Summary

  • Fill empty Portal submit filters from the resolved execution profile scopes
  • Keep Profile Exp as Portal-only matching metadata and omit it from GitLab CI variables
  • Add dry-run and submit coverage for Profile ID-only requests

Root cause / impact

The dev request did not fire because it was stored as submit_blocked with confirm_submit missing. While checking that path, Profile ID-only requests were also recording empty code/system values, which would make a confirmed trigger broader than the selected profile implied.

Validation

  • /home/nakamura/fugakunext/venv/bin/python -m py_compile result_server/routes/admin.py
  • /home/nakamura/fugakunext/venv/bin/python -m pytest result_server/tests/test_execution_profiles.py
  • /home/nakamura/fugakunext/venv/bin/python -m pytest result_server/tests/test_execution_profiles.py result_server/tests/test_result_metadata_index.py result_server/tests/test_api_routes.py result_server/tests/test_app_dev_security.py result_server/tests/test_preflight.py
  • /home/nakamura/fugakunext/venv/bin/python result_server/tests/run_result_server_tests.py

Signed-off-by: yoshifuminakamura <nakamura@riken.jp>
@yoshifuminakamura
yoshifuminakamura marked this pull request as ready for review August 6, 2026 00:22
@yoshifuminakamura
yoshifuminakamura merged commit 187ddfc into develop Aug 6, 2026
7 checks passed
@yoshifuminakamura
yoshifuminakamura deleted the feature/portal-profile-scope-trigger-vars branch August 6, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant