Skip to content

E2E scenario diagnose-fix-path-prepends-with-apostrophe-intact fails on Windows Strix Halo CI lane (pre-existing since #691) #700

Closed

Description

@jussielo-amd

Current behavior
The Windows Strix Halo self-hosted E2E lane (E2E tests (Strix Halo, Windows)) fails the scenario diagnose-fix-path-prepends-with-apostrophe-intact (tests/e2e-cucumber/features/diagnose.feature, @requires-os:windows). The cucumber reconciliation step reports it as an unexpected regression:

Reconciliation: 3 xfail (failed as expected), 0 XPASS (0 flaky, 0 stale), 1 unexpected failure(s).
FAIL: 'diagnose-fix-path-prepends-with-apostrophe-intact' was expected to pass on this host but FAILED — a regression.

Expected behavior
Fixing a missing PATH entry via rocm fix (the fix-6-path recipe on Windows, run_path_export_windows in crates/rocm-core/src/fix.rs) should prepend the HIP SDK bin dir to the real Windows User PATH while leaving an apostrophe already present on that PATH intact, per the scenario's own assertion.

Steps to reproduce
Not reproducible outside the self-hosted Strix Halo Windows runner (needs a real Windows host with the fixture's User PATH state). Observed failing on two separate PRs' CI runs for the same job:

Possible solution
Not investigated beyond confirming the regression predates and is independent of #666.

Your environment

  • rocm-cli channel: n/a (CI only)
  • Platform: Windows (self-hosted Strix Halo runner)

Relevant log output

Reconciliation: 3 xfail (failed as expected), 0 XPASS (0 flaky, 0 stale), 1 unexpected failure(s).
FAIL: 'diagnose-fix-path-prepends-with-apostrophe-intact' was expected to pass on this host but FAILED — a regression.

Additional context
Surfaced while reviewing #666 (ROCMAI-151). The scenario and the fix-6-path code it exercises are untouched by that PR, so this has been failing on main since #691 merged with the check already red — no tracking issue existed for it before this one.

Activity

  1. jussielo-amd commented on Oct 26, 2026

    @jussielo-amd
    CollaboratorAuthor

    This looks already fixed on main.

    The failing step was never the apostrophe assertion itself — it was the preceding step, "Then the CLI used PowerShell's SetEnvironmentVariable, not setx, to update the User PATH". That assertion banned the substring setx across the entire output of rocm fix fix-6-path --yes, but rocm fix <id> prints the fix-6-path catalog recipe before it runs anything, and at the time of #691/#666 that catalog's documented Windows command was itself setx PATH "%PATH%;C:\Program Files\AMD\ROCm\<version>\bin". The assertion tripped on the catalog's own documentation, not a real regression in the write path — confirmed directly from the #691 CI log (run 38712635607, job 116847390742): the real write used [Environment]::SetEnvironmentVariable(...) correctly, apostrophe intact (O''Brien properly escaped), right after the offending catalog text.

    PR #710 (0acf698d, merged 2026-10-19) fixed exactly this: the catalog's documented Windows command now shows the real SetEnvironmentVariable one-liner instead of setx (crates/rocm-core/src/fix.rs, crates/rocm-core/src/diagnose.rs), and the e2e assertion was scoped to the write region (user_path_write_region in tests/e2e-cucumber/src/lib.rs) so catalog prose mentioning setx can never trip it again.

    Verified live, not assumed:

    • 0acf698d is an ancestor of current main (63ecab2d).
    • Every E2E self-hosted run on main since fix(fix-6-path): stop advertising setx for the Windows PATH write #710 merged where the Windows job actually reached the e2e-cucumber suite passes diagnose-38 cleanly — e.g. run 39975715090, job 120489806918 (2026-10-23): both Then steps pass, reconciliation reports 0 unexpected failures.
    • The handful of red Windows-job runs since fix(fix-6-path): stop advertising setx for the Windows PATH write #710 are an unrelated infra flake (a 403 downloading therock-dist-windows-gfx1151-7.14.1.tar.gz from repo.amd.com during pre-warm, before the cucumber suite even starts), not this scenario.
    • The latest run on main (40317666753) has the Windows job green.

    Closing as fixed by #710.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions