Skip to content

Share one newest-install-first registry sort across rocm, rocm-core and vLLM #716

Open

Description

@rominf

After #566, the rule "newest install first, ties broken by runtime key, then path" exists in three hand-written copies:

  • sort_manifests_newest_install_first in apps/rocm;
  • sort_records_newest_install_first in rocm-core;
  • the vLLM engine's registry sort.

Each copy has its own tests. Because these copies are what keep the CLI, rocm-core's probes and vLLM picking the same runtime, they should be one helper in rocm-core that the other two call. The three test suites can then become one test of the shared helper, plus a check at each call site.

Raised in the review of #566.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions