Skip to content

probe: gitleaks allowlist check (do not merge) - #1008

Closed
jussielo-amd wants to merge 5 commits into
mainfrom
probe/gitleaks-allowlist-check-DO-NOT-MERGE
Closed

jussielo-amd wants to merge 5 commits into
mainfrom
probe/gitleaks-allowlist-check-DO-NOT-MERGE

Conversation

@jussielo-amd

Copy link
Copy Markdown
Collaborator

Throwaway pull request. Do not review and do not merge; it will be closed as soon as the scan result has been read.

It exists to run the repository's PR-time gitleaks scan, with the config of this branch, on a probe file that holds a random api_key literal, an api_model line and a mixed line, to confirm the allowlist entry of #1000 behaves as intended (the api_key literals are reported, the api_model and runtime_key fields are not) because gitleaks could not be run locally. All strings in the probe file are random, not credentials.

…rces in gitleaks

The generic-api-key rule flags test fixtures such as an api_model assignment of a model repository name and a runtime_key of a wheel install key, because the variable name contains api or key. Both are public identifiers. A pull request whose scan window reaches a commit containing them (the scan checks out a depth-limited merge ref, so history that includes merges from main or a stale base puts such commits at the window boundary, where the whole tree reads as added) fails the scan though it touches neither line. Allow exactly those two assignment shapes in Rust files, anchored on the line, so api_key assignments are still scanned.

Signed-off-by: Jussi Elo <jussi.elo@amd.com>
…he match, and cover both field shapes

Match against the rule's own match instead of the whole line, so a real credential on the same line is still reported under its own match. Accept both : and = for api_model and runtime_key, and a value character set that includes / and :, which covers all 33 assignments of these names in Rust sources on main instead of 24.

Signed-off-by: Jussi Elo <jussi.elo@amd.com>
…vides

The comment attributed the api_key exclusion to the Rust-only path limit; it comes from the two names the pattern lists. Also say that a JSON-style quoted key is not covered.

Signed-off-by: Jussi Elo <jussi.elo@amd.com>
…d-bearing

Review follow-up. Bound the allowlisted value to 64 characters so a long token assigned to api_model or runtime_key in a Rust file is still reported; the longest value assigned to either name on main is 39 characters. Also state in the comment that condition = AND is load-bearing: under the default OR the paths entry alone would allowlist every rule in every .rs file.

Signed-off-by: Jussi Elo <jussi.elo@amd.com>
Random strings only, for a CI scan experiment on the allowlist entry. Not declared as a module.

Signed-off-by: Jussi Elo <jussi.elo@amd.com>
@jussielo-amd

Copy link
Copy Markdown
Collaborator Author

Probe finished: the scan reported only the two api_key findings, as expected. Closing; the branch is throwaway.

@github-actions

Copy link
Copy Markdown
Contributor

Caution

2 potential secret finding(s) were committed in this pull request. Treat each credential as compromised and revoke or rotate it now, even if a later commit removed it. Deleting the line or force-pushing does not undo the leak: the commits stay reachable from this pull request and from every clone or fork, and automated scanners harvest secrets pushed to public repositories within minutes.

If a finding is a test fixture or a false positive, allowlist it in the configuration of the scanner that reported it.

Security scan found 2 critical or high finding(s) on lines changed by this pull request
Scanner Severity Rule Location Finding
Gitleaks HIGH generic-api-key crates/rocm-core/src/gitleaks_probe_throwaway.rs:10 Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
Gitleaks HIGH generic-api-key crates/rocm-core/src/gitleaks_probe_throwaway.rs:12 Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

View the security scan run for complete reports.

“New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant