Repository navigation
build(deps): bump sysinfo from 0.39.6 to 0.40.1 - #1024
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [sysinfo](https://github.com/GuillaumeGomez/sysinfo) from 0.39.6 to 0.40.1. - [Changelog](https://github.com/GuillaumeGomez/sysinfo/blob/main/CHANGELOG.md) - [Commits](GuillaumeGomez/sysinfo@v0.39.6...v0.40.1) --- updated-dependencies: - dependency-name: sysinfo dependency-version: 0.40.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Security scan found no critical or high findings on lines changed by this pull requestView the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
jussielo-amd
left a comment
There was a problem hiding this comment.
Thanks for the bump. It can't merge as-is: sysinfo 0.40 has breaking API changes and the PR changes no .rs files. Static review only; the compile error below is from the CI log, the rest I checked against the sysinfo v0.40.1 source and did not compile.
Blocking: crates/rocm-core/src/disk_space.rs:233-237 (listed_mounts) no longer compiles. In 0.40 Disks::new_with_refreshed_list_specifics returns Result<Disks, sysinfo::Error> and Disks::list() is removed. CI fails with error[E0599]: no method named 'list' found for enum Result<Disks, sysinfo::Error> at disk_space.rs:237, which breaks clippy, coverage, build-and-test and the Windows jobs. Suggested fix: let Ok(disks) = sysinfo::Disks::new_with_refreshed_list_specifics(...) else { return Vec::new(); }; then disks.iter().map(...). An empty list makes mount_for_path return None, which the callers already treat as "unknown, never block the operation".
Blocking: crates/rocm-dash-collectors/src/host.rs:24 and :41 will break next, but CI has not reached them because compilation stops at rocm-core. In 0.40.1 System::new_with_specifics returns Result<Self, Error> (so sys.refresh_cpu_all() is called on a Result), and Cpu::cpu_usage is now Cpu::usage. HostCollector::new() is infallible today, so it needs either a Result return or a fallback.
Blocking: the "Third-party notices current" check is also red. MANIFEST.md:473 and THIRD_PARTY_NOTICES.txt:11170 still list sysinfo 0.39.6. Please regenerate them (cargo xtask manifest and cargo xtask tpn) once the code compiles.
Happy to re-review once the source changes land on this branch.
🤖 by agenthub on AMD AgentHub
|
Superseded by #1035, which carries the same sysinfo 0.40.1 bump together with the source changes the new API requires (fallible |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps sysinfo from 0.39.6 to 0.40.1.
Changelog
Sourced from sysinfo's changelog.
Commits
75dcd2cMerge pull request #1790 from GuillaumeGomez/update15a5e93Update crate version to0.40.14f252bdUpdate CHANGELOG for0.40.14a7b9e7Merge pull request #1789 from GuillaumeGomez/fromb19150aAdd backFrom\<X<Y>> for Vec\<Y>implementations forUsers,Groupsand `G...e27239aWindows: markSystem::load_averageas unsupported (#1788)70c58c7Fix wrong supported system list forGPUs13e94d5Windows: markSystem::load_averageas unsupported34677feallow getting ownedDiskfromDisks(#1786)48972c4Merge pull request #1784 from GuillaumeGomez/updateYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)