Repository navigation
Conversation
Security scan found no critical or high findings on lines changed by this pull requestView the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
volen-silo
left a comment
There was a problem hiding this comment.
I reviewed the whole change: every file in the diff, plus the CLI code the skill drives (apps/rocm, and the diagnose, fix and examine code in rocm-core). I checked each command, flag, status and JSON field the skill names against the code, and they all exist and behave as the skill says. That includes --yes exiting 5 when there is no terminal, the fix-4 preconditions, and the installer defaults. Single-quoting with --symptom='...' closes a real command-injection path. The = form also stops a paste like -1073741819 from being read as a flag. Replacing the hand-kept exit-code table with the manifest's exit_codes is the right call.
I've requested changes for the reasons in the inline comments below. None of them is a deep problem. The one that changes what an agent does is the vLLM startup case on SKILL.md: it sends a symptom the catalog covers to an upstream tracker. The rest are test and comment accuracy. Some of the comment fixes overlap items already filed as ROCMAI-955 follow-ups. I flag them here anyway because they sit in the comment block this PR rewrites, so fixing them now costs almost nothing.
One check outside the diff: on 8610f5e, E2E tests (Strix Halo, WSL2, current) is red. It failed in the "Install Ubuntu-24.04 distro" step, before any test ran, so it looks like infrastructure. The same check is green on main's tip, though, so please rerun it. The MI300X and W7900 lanes were still queued when I looked.
What I ran on this head: test_hooks.py (14 pass), cargo nextest run -p xtask eval_fixtures (24 pass), cargo xtask eval-fixtures --check (clean), and skillscope structural on the skill (OK). I did not run the skill e2e scenarios locally (CI's mock lane is green), and not the model-graded routing or behavioral evals.
One question rather than a request: when the user names no vendor, Phase 0 asks to install the CLI before anything has shown there is an AMD GPU (rocm examine reports no-amd-gpu only afterwards). I see why: nothing can probe without the CLI, and the scope gate catches a vendor the user names. Is that ordering deliberate?
| space instead, a paste that begins with `-` (an exit code such as `-1073741819`) | ||
| is read as a flag and the command fails. | ||
|
|
||
| If the user pasted no error text, run `rocm diagnose --json` without |
There was a problem hiding this comment.
A vLLM startup failure described in words, with no error line pasted, gets routed upstream even though the catalog covers it. Step 1 says to run rocm diagnose --json without --symptom when nothing was pasted. But both vLLM checkers ignore the examination and score only the symptom text. check_16_vllm_oom (crates/rocm-core/src/diagnose/engine.rs, around line 132) returns zero(...) when no anchored vLLM line is present. So "vLLM runs out of memory at startup" gets has_match: false, and step 2 sends it to a tracker, though the description lists that symptom as a trigger.
Suggest: for a vLLM startup complaint, ask for the exact error line first (or the rocm diagnose --symptom '...' command rocm serve printed), then diagnose.
There was a problem hiding this comment.
Fixed in f78bbc2. You're right: both vLLM checkers score only the symptom text, so a description in words can't match either entry. The vLLM section now says that for a vLLM startup failure on Linux or WSL2 described in words, with no error line pasted, the agent asks for the exact error line (or the rocm diagnose --symptom '...' command rocm serve printed) before diagnosing. Step 1's "no error text pasted" paragraph points there instead of repeating it.
df9c981 adds an eval case for it, rocm-vllm-failure-in-words-asks-for-the-error-line. Its premise test pins that the replayed diagnosis for the description has has_match false and lists neither vLLM entry. Letting a described failure match would need a change to the matcher, which is out of scope for this PR.
| beside a discrete GPU), so a healthy host still returns a non-empty | ||
| `matched` of sub-threshold entries. Gating on emptiness proposes a fix for a | ||
| machine with nothing wrong. | ||
| - `matched[]` — ranked causes, each with `id`, `title`, `score`, `evidence[]`, |
There was a problem hiding this comment.
Nothing ties the exit_codes names and fix.* field names quoted here to the CLI. the_published_exit_codes_are_the_ones_apply_returns (crates/rocm-core/src/fix.rs) pins the manifest's keys, not the names this file quotes. skill-04 deliberately skips the fix sub-fields. Not a regression, since the old table wasn't parsed either, and the agent reads the map at runtime. But a small unit test would be cheap: every backticked exit_codes name in SKILL.md must be a manifest key.
There was a problem hiding this comment.
Done in f78bbc2, with two tests in tests/e2e-cucumber/tests/skill_reference.rs:
exit_code_names_listed_in_the_skill_are_the_manifest_failure_exits: the exit-code list in step 3 (the bullets after "by itsexit_codesname") must equal the manifest's non-zeroexit_codes. That's stricter than you suggested: a published exit the skill leaves out fails too.fix_fields_quoted_in_the_skill_exist_in_the_diagnosis_json: every field in step 1'sfixfield list must be a key of a serialisedrocm_core::Fix.
Both read the whitespace-collapsed text, so re-wrapping doesn't matter, and both fail loudly if their anchor phrase disappears. One limit: only those two lists are parsed. The other fix.<field> mentions in the prose (fix.class, fix.needs, fix.commands) are fields from that same list, but nothing parses them where they appear.
| fn render_plan(fix_id: &str, title: &str, fix: &rocm_core::Fix) -> Result<String> { | ||
| // No `auto` entry needs a reboot today, so the plan has no line for one: refuse | ||
| // rather than print a plan that leaves the requirement out. | ||
| if fix.class != rocm_core::fix::FixClass::Auto || fix.needs_reboot { |
There was a problem hiding this comment.
render_plan re-implements the CLI's plan rendering: the flag strings ("requires sudo", "requires re-login", "rocm fix can run it") and their order, from format_flags in crates/rocm-core/src/fix/render.rs. It also takes Verify: from the diagnosis, not the recipe. For fix-4 that gives ... && ls -l /dev/kfd && rocminfo | head -n 5, which the recipe in fix/catalog.rs doesn't have. --check compares the recordings to this generator, not to the CLI. So a wording change in format_flags would leave rocm-apply-auto-fix-needs-consent grading the agent against text the CLI no longer prints. The dropped Note: and other lines are disclosed; the duplicated flag logic isn't.
Suggest: make format_flags reachable from xtask and call it, or add a test that renders fix-4 both ways and compares the Flags: line.
There was a problem hiding this comment.
Fixed in df9c981, and the fix goes further than format_flags. render_plan and its tests are gone. rocm-core now builds the whole plan in one function that print_recipe uses, with unchanged output, and exposes it as a #[doc(hidden)] rocm_core::fix_plan_text(id, os). The generator replays that function's output. So the flags line, the Note: lines and Verify: all come from the recipe, as rocm fix prints them. The fix-4 replay's Verify: no longer has the diagnosis's ls -l /dev/kfd. The refusal message and the dry-run notice are now constants the CLI prints and the generator reuses.
What's still not the CLI's: the runner's Will run: line is left out because it names the user and the machine. The layout around the plan (a blank line, then the notice) is written by hand in the generator and checked only against the committed replay. The module doc and docs/testing.md both say this.
| stub then answers `rocm fix <id> --dry-run` (the flag before or after the id) and | ||
| `rocm fix <id>` with no flag, and never `--yes`, so an agent that applies before the | ||
| user said OK meets the stub's refusal and the transcript shows the command. The | ||
| generator accepts only an `auto` entry that needs no reboot, since the plan has no line |
There was a problem hiding this comment.
This misses one requirement. Besides being an auto entry with no reboot, the apply fix id has to be one the replayed diagnosis actually matches, given the case's symptom and host. Otherwise plan_text fails with "the replayed diagnosis carries no match for {fix_id}". The error is loud, but nothing here says so. Suggest adding "and the case's symptom and host must make the replayed diagnosis match it" (same for the module doc in xtask/src/eval_fixtures.rs).
There was a problem hiding this comment.
Fixed in df9c981. docs/testing.md and the module doc in xtask/src/eval_fixtures.rs now say that the fix must be auto on the host's platform (wsl for the WSL host, otherwise linux) and that the case's symptom and host must make the replayed diagnosis list it at or above min_score_for_match. Otherwise the generator fails with "the replayed diagnosis carries no match for ...". A test pins that error.
The "no reboot" condition is gone: the plan now comes from the CLI's own renderer, so the generator no longer has a reboot line it can't print.
| Host::AmdFound | Host::ContainerSmallShm => ("ok", true), | ||
| }; | ||
| let value: serde_json::Value = | ||
| serde_json::from_str(&examine.stdout).expect("an examination is JSON"); |
There was a problem hiding this comment.
Just below, around line 612: assert_eq!(examination.status, examination.compute_status()) can't fail. examination_for ends with examination.status = examination.compute_status(); (line 292), so it compares a value with itself, while the comment says it checks "the status in the file". The assertion predates this PR, but the new ContainerSmallShm host now relies on it. Suggest deleting it, or deserializing examine.stdout and comparing its status with compute_status().
There was a problem hiding this comment.
This was fixed on main by your #1047, which removed that assertion. The test now checks the status and has_amd_gpu in the replayed examine JSON against fixed values for each host. This branch is rebased onto it. The new ContainerSmallShm host is held to the same check (ok, true), and it's also in the test that runs each host over a contradicting base. Nothing in this PR changed that assertion.
|
|
||
| #[test] | ||
| fn a_case_id_cannot_escape_the_fixtures_directory() { | ||
| let (_tmp, root) = scratch(); |
There was a problem hiding this comment.
On pin_problems (around lines 1077-1084, outside this diff): only the "pin quoted in skill text" check has a test (a_pin_the_skill_text_quotes_is_caught). The other two, "pins nothing" and "pin not in its replay", have none. Deleting either keeps every test green, because the committed data satisfies both. The 8 new cases rely on them, so two scratch-copy tests like the existing one would be worth adding: one blanks a logs_contain, one pins a string absent from the replay.
There was a problem hiding this comment.
Done in df9c981. There are two scratch-copy tests, built like a_pin_the_skill_text_quotes_is_caught. a_replayed_case_that_pins_nothing_is_caught empties a case's logs_contain. a_pin_the_replay_does_not_print_is_caught pins text the replay never prints. Each one asserts the problem message for its check.
| @@ -15,8 +15,8 @@ Feature: The ROCm Doctor skill's instructions match the CLI they drive | |||
| # | |||
There was a problem hiding this comment.
In this header block (lines 11 and 34-36): the two tags cited from diagnose.feature don't exist as written. The real ones are @id:diagnose-fix-inapplicable-here-is-declined-not-attempted and @id:diagnose-fix-catalog-is-complete. Line 11 also says "a 16th failure mode", and the catalog now has 29. All three predate this PR, but this PR rewrites the block, and AGENTS.md §3 relies on cited @id:s being real. Suggest adding the diagnose- prefix and saying "a new failure mode".
There was a problem hiding this comment.
Fixed in f78bbc2. The header now cites @id:diagnose-fix-inapplicable-here-is-declined-not-attempted and @id:diagnose-fix-catalog-is-complete, which both exist in diagnose.feature. The third tag it cites, @id:diagnose-json-states-when-nothing-matched, was already correct. "A 16th failure mode" is now "a new failure mode".
| @@ -718,8 +718,10 @@ async fn assert_documented_fields_present(world: &mut E2eWorld) { | |||
| // offered is fully readable by an agent following the skill. | |||
There was a problem hiding this comment.
The comment at lines 642-645 (outside this diff) is now stale. It says "marker cells above, per-host prose below ... the prose is what an agent reads before it decides whether to offer to run a fix". In the rewritten reference.md the per-host bullets sit above the table, and SKILL.md now tells the agent to read fix.class. The PR's known-gaps list mentions this; suggest fixing it here. Say the prose is checked so it can't drift from the table, and drop "what an agent reads".
There was a problem hiding this comment.
Fixed in f78bbc2. The comment now says the reference states it twice, as per-host bullets above the table and as marker cells in it, and that the bullets are checked too so they can't drift from the table. "What an agent reads" is gone.
|
I ran the Windows, WSL2 and sudo claims in this skill on real machines (Windows 11 and WSL2 on one AMD Strix Halo box, CLI built from 1. Quoting for PowerShell and cmd.exe (
Suggested replacement for "In any other shell (PowerShell, cmd.exe), … written in the quoting of their own shell":
The "keep the 2. 3. sudo with no terminal (
Suggested replacement: "If the fix has Confirmed as written: on native Windows, |
An agent following the skill literally would have acted on things the CLI does not do. This brings SKILL.md and reference.md in line with the CLI source and with what `rocm` prints. Deciding what a diagnosis supports: step 2 is one ordered list that covers out_of_scope, a native-Windows vLLM symptom, a symptom naming an app, PyTorch or llama.cpp, and a match whose evidence does not explain what the user described. Many entries score from host state alone, so every match that clears the threshold is checked, not only the top one, and the one that explains the problem is acted on; the check is keyed on the problem the user described, not on whether text was pasted. Any host-only match that clears the threshold is offered as worth doing anyway and never as the remedy; routing the problem upstream applies only where no match explains it. A `--model` question is answered from its `model` object and is not routed upstream on has_match. The no-match routing decision is stated once: a failure of `rocm serve` itself, with any engine, goes to this project's tracker (it is rocm's own run of the engine, and `route_when_no_match` follows the host's framework) and is checked before the app-named-in-the-symptom rule, and the CLI's trailing note on the pytorch route is relayed as advice. The `fix` fields the skill acts on are named once, in step 1, and `notes` are relayed with the plan and with a diagnose-only explanation, since they carry warnings the user must see. Applying a fix: `rocm fix` refuses in a non-interactive shell without `--yes`, so the skill goes dry-run, the user's OK, then `--yes`, and names the argument a needs-argument fix takes. A need for a new session (re-login, reboot, new terminal) is said with the proposal, before the OK, and so is that a `sudo` fix may fail under `--yes` from an agent's shell (no input, one-minute limit). A non-zero exit is read by its manifest `exit_codes` name together with the output, with a remedy for each and the same treatment for an exit the map does not name; `--dry-run` is not offered after `not_applicable`, which it exits with too, and the fix commands are handed over when the cause is a precondition. For a `--distro` diagnosis the skill does not run `rocm fix` on the Windows host and hands the user the fix commands to run inside the distribution. The exit-code table in reference.md, which nothing pinned, is dropped. Install: the consent text says the installer installs the CLI, edits the user's PATH configuration, writes its own config under the home directory and prints what it changed, with its opt-out; `nightly` is described as a moving tag, and the CLI is re-checked by the full path the installer reports. Symptoms: the pasted text is passed as `--symptom='<text>'`, which keeps a leading `-` from being read as a flag. For bash and zsh it is single-quoted so a paste cannot run as a command, with a `'` in the paste written `'\''`; for any other shell the user is handed the command and asked to paste the JSON back. The `vllm: ` prefix is added only when vLLM is known to have printed the line, a `rocm diagnose` command printed by `rocm serve` is run with `--json`, and fix-17 relays the CLI's confidence. Reference: `model.warnings[]` is named as the field that carries the note on which options `rocm serve` does not take; Typical-signal cells are short handles with no score arithmetic and the CLI's score and evidence decide; the diagnose section documents the `--distro`, `--report`, `--send` and `--top` flags (`--distro` and `--report` as alternatives, `--send` not with `--json`) and the `model` object, and the `fix` and `model` field lists are cut to the fields the skill acts on; the Marker spelling is said to be lower-cased; rules stated in both files are kept in one, with a pointer from the other; the Out of scope section and the Linux-only/Windows-only recap, which restated SKILL.md and the table, are removed. Routing: a symptom naming both an app in Framework routing and PyTorch or llama.cpp goes to the app's tracker, and the published skill cites no source file or line. vLLM: a startup failure described in words matches neither vLLM entry, so the skill asks for the exact error line (or the diagnose command `rocm serve` printed) first on Linux or WSL2 instead of diagnosing without a symptom. Tests: two tests in skill_reference.rs hold the exit-code list in SKILL.md equal to the manifest's non-zero `exit_codes` and every `fix` field it names to the diagnosis JSON. Both read only the list after their marker and match on the whitespace-collapsed text. A missing marker, a `fix` field list that names no field, and a field name that is not lower-case snake_case fail loudly; a wrong exit-code list fails the comparison. The fixture sentences SKILL.md must keep are listed once, in skill_reference.rs. Rules: a `suggestions[]` entry of a model estimate is relayed as the llama.cpp option it names and never written into a `rocm serve` command, which takes no context size, KV cache type or GPU layer count; "never invent a fix" is scoped to what the CLI returns, a diagnosis `fix` or the steps in `model.fix`; and `model.warnings[]` is described as carrying the standing note only for a GGUF estimate that was compared with the GPU. Also: the advice-only entry is named where step 1 describes advice, the description gains a boundary against first-time setup, the CPU-fallback ban from the assistant policy is carried over, LM Studio is routed to its public bug tracker, a failed install is in scope and a first-time setup request is not. AGENTS.md no longer counts the SKILL.md fixture sentences; it points at the module doc of skill_reference.rs, which lists them all. Comments and messages in the CLI crate and the e2e suite that pointed at the removed exit-code table, the removed recap, or `auto_applicable` as what the skill reads now point at the manifest's `exit_codes`, at a paragraph that still exists, or at `fix.class`, and the runner comments speak of the `auto` class and of fix-9 as `needs-argument`. No behaviour changes outside the skill. Corrections from a hardware run and its review: a pasted symptom is quoted for PowerShell and cmd.exe only when it is one line with no `"`, `\` or `%`, and otherwise the user is asked for a single line or to quote it themselves; the fix-19 row says only that the entry fires under 1 GiB of `/dev/shm` (a container defaults to 64 MB); the `needs_sudo` disclosure says what happens with and without a controlling terminal (sudo is killed after one minute, and an unanswered prompt ends in the `failed` exit). A diagnose-only match is relayed with its `summary` and `notes` and offers no fix, the apply sub-steps are lettered so step 4 is unambiguous, the routing-follows-the-host rule is stated once, and the guard test and READMEs name the fixture sentences from one place. Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
The skill text carries rules no eval reached: asking before applying an auto fix, telling a match that explains the pasted error from one that only reflects the host, routing Lemonade, Ollama, LM Studio and PyTorch-named failures and a failure of `rocm serve` itself, passing a paste as one literal argument, never suggesting a CPU route, asking for the error line when a vLLM startup failure is described in words, disclosing a sudo fix and what the installer changes before asking for consent, and declining a first-time setup on a clean machine. Add replayed cases for each, with judged expectations rather than pins the skill text itself satisfies. The routing prompts name the vendor (AMD), so the agent does not stop at `rocm examine --json`, which those replays refuse. The vLLM case's premise, that the description matches nothing, is pinned. A container host with the default shared-memory size lets the replay hold a host-only match above the one that explains the paste, and a second case holds a host-only match as the only match that clears the threshold; every host states its container and `/dev/shm` fields, and a test with a contradicting base asserts them. A test pins the premise each judged case rests on, so a catalog change cannot silently void it. The stub answers the dry run and the unflagged `rocm fix <id>` from the replayed catalog, rendered by `cargo xtask eval-fixtures` like every other recording, so the existing check covers it, and it takes `--dry-run` before or after the id as the real command does, never answering `--yes`. The plan it prints is the CLI's own: rocm-core exposes `fix_plan_text`, a shared plan builder extracted from `print_recipe`, and the refusal and dry-run strings and the `declined` exit as constants the CLI prints from its own code paths and the generator reuses, so the replay cannot drift from the CLI. `print_recipe`'s output is unchanged, and every new export is `#[doc(hidden)]`, like the crate's other test seams. Only the runner's `Will run:` line, which names the user and the machine, is left out. The print-only fallback has one home on the recipe, `FixRecipe::class_on_os`, instead of copies. The platform comes from the host, so the WSL host, where `rocm fix` reports a Linux-only fix as not applicable, is refused with a clear message, and an unknown id is reported as unknown. Only an `auto` entry is modelled, the apply fix must be one the replayed diagnosis matches and must clear the match threshold, and a fix that is not `auto` on the host's platform is refused, with a test. The apply-match guard is tested with a paste that makes a different fix clear the threshold. The needs-argument wording of the plan is pinned. The apply items about logging out and `sudo` rest on `needs_relogin` and `needs_sudo` being set for the replayed fix, which the premise test asserts, and the two vLLM cases that rested on a recorded score pin their premises. The two `pin_problems` checks that nothing exercised (a case that pins nothing, a pin its replay does not print) are now tested. The testing and skill-quality docs are brought in line with what is replayed. They say the layout around the plan is written by hand and checked only against the committed replay. Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
8610f5e to
df9c981
Compare
Thanks for running these on real hardware. All three corrections are in f78bbc2, two of them narrower than your text:
|
|
I rebased onto main and force-pushed (now df9c981). The changes address the review and the hardware-run comment:
Known gaps:
On the two points in the review body: Phase 0 offering to install before anything shows an AMD GPU. Yes, that's deliberate. Nothing can probe the machine without the CLI. If the user names NVIDIA, Intel or Apple, the scope gate declines before Phase 0 runs. If they name no vendor, ROCm or HIP wording is treated as AMD, and the install only runs with the user's consent, after the skill has said what the installer changes. Once the CLI is in place, step 1 runs
Ready for another look once CI is green on the new head. |
Why
The
rocm-doctorskill had drifted from what therocmCLI actually does, and an agent following it literally could go wrong in ways found by reading it against the CLI source and running the read-only commands:rocm fix <id>was assumed to prompt. In an agent's shell with no terminal it refuses and exits 5, which the skill's text invited reporting as "you declined" when nobody had been asked.--symptomargument, so$(...)or a backtick in the paste ran as a command, and a paste starting with-(for example-1073741819) was read by clap as a flag.fix-10andfix-19(host-state matches) outrankfix-17-torch-dlpackfor alibtorch_cuda.sopaste, so the cause the user pasted was dropped and an unrelated host finding was presented as the remedy.What changes
exit_codes, thresholds by name (min_score_for_match,high_confidence_threshold), and the apply decision fromfix.class. The hand-kept exit-code table is gone.--yes; each exit is read by manifest name together with the output, and adeclinedexit without--yesmeans nobody was asked.--symptom='<text>'is single-quoted with'\''for an apostrophe in POSIX shells; in any other shell the user is handed the command to run.rocm serve --engine lemonaderoute, the LM Studio tracker, and a no-CPU-fallback statement are rewritten or added; SKILL.md and reference.md each own their rules once.skills/rocm-doctor/evals/): new replayed cases for the apply sequence, the "match does not explain the paste" and "host-only match" decisions, Ollama / LM Studio /rocm serverouting, shell metacharacters in a paste, the no-fix control, an installer-disclosure expectation, and a clean-machine should-not-trigger case. The apply answers are generated bycargo xtask eval-fixturesfrom the catalog and the replayed diagnosis, so--checkcovers them, and the stub never answers--yes.rocm-corethat cited the removed exit-code table or described the old text were corrected; no CLI behaviour changes.Verification
AGENTS.md §3: this PR changes the skill's instructions to an agent, not CLI output, exit codes, files or engine selection, so the behavioural coverage is the evals above. The existing scenarios that pin the skill's documents to the CLI still pass:
skill-catalog-ids-match-cli,skill-auto-fix-set-matches-cli,skill-os-scope-matches-cli,skill-diagnosis-matches-what-the-skill-documents,skill-examine-verdicts-are-documented,skill-escalation-target-matches-cliandskill-required-contract-is-the-one-the-cli-publishes.Run locally on this head:
cargo fmt --all --check;python3 -B -m unittestonevals/test_hooks.py(14 pass, 1 Windows-only skipped);cargo test -p xtask eval_fixtures(24 pass);cargo test -p e2e-cucumber --test skill_reference(3 pass); the skill scenarios throughcargo xtask e2eagainst a prebuiltrocm(7 scenarios, 25 steps pass). Each new stub and replay test was broken on purpose (an apply branch widened to accept--yes, a replayed flag dropped, a premise changed) and watched fail before being restored. The change was reviewed independently against its base until no blocking findings remained.Not verified:
behavioralandroutinggrading described in docs/skill-quality.md; those make paid model calls and are not part of this repository's CI.--symptomquoting form for PowerShell and cmd.exe (the skill hands the user the command there); theirm | iexinstall updating PATH in the same session and the Windows full-path form& "$env:USERPROFILE\.local\bin\rocm.exe" --version;rocm diagnose --distrofrom a Windows host followed byrocm fixacting on the host (the skill tells the user to run fixes inside the distribution); whethersudoprompts or fails fast whenrocm fix fix-4-render-group --yesruns from a shell with no terminal.For maintainers to decide
rocm serveitself with no catalog match, any engine, now goes to this project's issues rather than to the tracker for the host's detected framework; CONTRIBUTING.md names this project's issues for bugs here, androute_when_no_matchfollows the host framework, which says nothing about whose bug it is.autofixes such asfix-4.--n-gpu-layerssuggestion (some layers in system RAM) is allowed alongside the no-CPU-fallback statement; confirm that is within the policy.lmstudio-ai/lmstudio-bug-tracker, a public repository; it was not confirmed as LM Studio's documented place for bug reports.fix-8-wheel-rocm's title says "ROCm major" but the code compares X.Y; the skill uses the CLI's wording. A--symptom-fileoption and a per-match flag saying whether the symptom contributed would remove the quoting rules and the "does it explain the paste" judgement from the skill.Known gaps in this change
OS scope:,Rationale:,Will run:,Note:andVerify (Linux, WSL):lines the CLI prints, which is harmless forfix-4(the only apply case; the generator refuses other ids) but is not fully listed in docs/testing.md.tests/e2e-cucumber/tests/e2e/skill_steps.rsstill says reference.md's per-host auto prose is what the agent reads before offering a fix.Checklist
tests/e2e-cucumber/expectations.tomlfor the fixed ticket ID and removed/narrowed any now-stale xfail rows. Not applicable: no CLI bug is fixed here and no xfail rows concern the skill.docs/architecture.md. Not applicable: no subcommand or subsystem is added.docs/architecture.mdhas the matching entry. Not applicable: no production source file is added, renamed or removed (the new files are eval fixtures).