Repository navigation
feat(examine): probe Vulkan instead of inferring it from the gfx table #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ROCMAI-550-vulkan-support-messaging
Are you sure you want to change the base?
Changes from all commits
5eb84a0
65a24f8
7162f91
16ccfb3
49e23e3
daed78d
bce633d
f54a8d2
aba912c
a426460
4545d36
fbd1134
cabe979
1e4b6cd
ab2b609
53b5cdb
3807d61
5309936
74a1496
c6e6218
767c586
2ef8add
50ff66a
8bde91a
c3e6bf2
a4dc753
5bda371
794e4b6
30144c5
d24a38d
6eef7b3
182915c
4ff8d08
c837335
773129e
90a31c3
33162c3
06ce905
cc3dc5a
b4479e5
3ac4f8b
a4dd8a6
bf2a323
60aa288
2ee299a
671fa86
795ca92
3480803
d9b16c9
e443ed6
f2be7af
2a7d923
ea647e0
05df6f9
6dfdb72
e95cb02
e2ebf99
96de042
e2447af
816ac1d
6de4ad5
aaade2d
725109d
604faa3
79f1227
0d5fe99
1bc2bad
d35ac5f
c7d0ee3
b18772d
da8437e
f91322a
e7b6513
fa9c1fc
0c7e432
069ba0e
d9af387
8fec79c
3d59dbc
a6fb45c
1dc93a4
209f90a
62190c6
47228b1
30f91a0
1cd9609
c97969d
21b2383
fbf0ad3
b7e77e8
1540bda
16ccdf9
8b811d6
0cce209
c809af3
5fc570f
ab87a90
f3a33ca
bf77372
d02e760
8f37693
7bb830f
b658e3c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,14 +63,18 @@ pub(crate) struct Cli { | |
| pub(crate) enum Command { | ||
| /// Check this computer's GPU, ROCm install, engines, and setup folders. | ||
| /// | ||
| /// A `rocm_support` line is printed on every host, at one of three | ||
| /// levels: ROCm/HIP-supported, Vulkan-only, or unknown. Vulkan-only covers | ||
| /// a GPU that is recognized but has no ROCm build at all (`gfx90c`, the | ||
| /// Vega iGPU in Renoir, Lucienne, Cezanne and Barcelo APUs), which still | ||
| /// works through Lemonade's Vulkan backend. Unknown covers both no GPU | ||
| /// detected and a target this build's catalog does not recognize: those | ||
| /// are detection gaps, not a verdict on the hardware, which is why an | ||
| /// empty `compatible_therock_family` does not read as a failed probe. | ||
| /// A `rocm_support` line is printed on every host, at one of five | ||
| /// levels: ROCm/HIP-supported, Vulkan-only, Vulkan-unconfirmed, no GPU | ||
| /// backend, or unknown. The three middle levels are decided by probing for | ||
| /// a Vulkan driver rather than by the gfx table: a GPU that is recognized | ||
| /// but has no ROCm build at all (`gfx90c`, the Vega iGPU in Renoir, | ||
| /// Lucienne, Cezanne and Barcelo APUs) runs through Lemonade's Vulkan | ||
| /// backend only if a driver is actually installed. Vulkan-unconfirmed means | ||
| /// the probe could not reach an answer, which is not the same as finding | ||
| /// none. Unknown covers both no GPU detected and a target this build's | ||
| /// catalog does not recognize: those are detection gaps, not a verdict on | ||
| /// the hardware, which is why an empty `compatible_therock_family` does not | ||
| /// read as a failed probe. | ||
| Examine { | ||
| /// Emit the machine-readable Examination JSON (for diagnosis tooling). | ||
| #[arg(long)] | ||
|
|
@@ -1011,11 +1015,7 @@ pub(crate) enum RuntimesCommand { | |
| /// generation and exact GPU target as its manifest recorded them. A fact | ||
| /// recorded nowhere, or recorded blank, is shown as `unrecorded`; nothing | ||
| /// is guessed from other facts. | ||
| List { | ||
| /// Print the runtime list as JSON instead of text. | ||
| #[arg(long)] | ||
| json: bool, | ||
| }, | ||
| List, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Blocking: This PR's title and description are about probing Vulkan instead of inferring it from the gfx table. Removing a scripting-facing Suggested fix: either restore |
||
| /// Use the selected ROCm runtime by default. | ||
| Activate { | ||
| /// Runtime key or friendly runtime selector. | ||
|
|
@@ -2165,24 +2165,6 @@ mod tests { | |
| } | ||
| } | ||
|
|
||
| /// `--json` belongs to `list` alone: bare `rocm runtimes` stays the text | ||
| /// listing, so a script has to name the subcommand to get JSON. | ||
| #[test] | ||
| fn runtimes_json_is_a_list_flag() { | ||
| for (args, json) in [(&["list", "--json"][..], true), (&["list"][..], false)] { | ||
| match parse_runtimes(args).expect("runtimes list parses").command { | ||
| Some(Command::Runtimes { | ||
| command: Some(RuntimesCommand::List { json: parsed }), | ||
| }) => assert_eq!(parsed, json, "{args:?}"), | ||
| other => panic!("expected runtimes list, got {other:?}"), | ||
| } | ||
| } | ||
| assert!( | ||
| parse_runtimes(&["--json"]).is_err(), | ||
| "`rocm runtimes --json` must be rejected, not read as `list --json`" | ||
| ); | ||
| } | ||
|
|
||
| fn parse_serve(args: &[&str]) -> Result<Cli, clap::Error> { | ||
| let mut argv = vec!["rocm", "serve", "qwen"]; | ||
| argv.extend_from_slice(args); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a Vulkan GPU driver was found here" is not what Vulkan-only guarantees: an unprobed platform / older
remote doctorsummary also yields Vulkan-only (render hedges it). Qualify the row.