Repository navigation
fix(dash): bound chat tool output so a small-context model can answer #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
630154a
fix(dash): bound chat tool output so a small-context model can answer
r0x0r ede0719
test(e2e): cover the model catalog a tool-using client is given
r0x0r 74c835d
fix(dash): keep a truncated tool result a failure when the command fa…
r0x0r 9d73961
Merge remote-tracking branch 'origin/main' into fix/dash-chat-tool-ou…
r0x0r 8c04cb8
Merge origin/main into fix/dash-chat-tool-output-cap
r0x0r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking: this dispatch change silently disables the CLI chat's deterministic "ROCm CLI summary" block for model questions.
run_rocm_read_only_in_process's["model"]/["models"]arm now returnsrender_model_registry_text_with_context_and_host's curated output. Its header comes frommodel_catalog_header(apps/rocm/src/model_catalog_text.rs), which prints"Recommended models - run one with \rocm serve `"(or the signed-index variant) — never the string"model recipes". Only the verbose renderer (render_model_registry_verbose_text_with_context_and_host) still emitswriteln!(output, "model recipes")`.deterministic_model_tool_summary(apps/rocm/src/chat/summaries.rs:320-321) is strictly gated ontool_text.contains("model recipes").run_chat_read_only_tool's"rocm_command"arm (this file, ~line 708) feeds exactly this dispatch's output intoturn.rs'sfollow_up_text, which is then passed straight todeterministic_chat_tool_summary(apps/rocm/src/chat/turn.rs:326).So on
rocm chat --prompt --tools— a sibling surface this same function serves — the "ROCm CLI summary" block (Recommended local assistant/Fit/Engine) that used to render whenever the model asked what it could run no longer appears, not because the feature was removed but because the one string it keys on is no longer produced by the new default path. Every existing test ofdeterministic_model_tool_summary/deterministic_chat_tool_summary(e.g.deterministic_model_tool_summary_suppresses_extra_local_model_follow_upinturn.rs, and the fixtures insummaries.rs) hand-writes a string containing"model recipes"literally rather than calling the real renderer or dispatch, so none of them catch this; no e2e scenario exercises it either.Confidence 88 — traced end to end at the PR head commit: confirmed the new default output never contains the gate string, confirmed the consumer's exact gate, and confirmed the call chain connecting this dispatch to that consumer.
Fix: either make the summary recognize the curated output too (key off a stable marker both renderers share, or off the tool name/args rather than parsing renderer-specific text), or if this deterministic summary is deliberately being retired for
model/models, remove it (and its now-stale fixtures) and say so in the PR description.