Skip to content

tests: reference the serve-27 xfail row's tracker as rocm-cli#1058 - #1065

Merged
tomastola merged 1 commit into
mainfrom
ci/serve-27-xfail-bug-ref
Nov 12, 2026
Merged

tomastola merged 1 commit into
mainfrom
ci/serve-27-xfail-bug-ref

Conversation

@tomastola

Copy link
Copy Markdown
Collaborator

Follow-up to #1018 (review point from juhovainio).

The serve-aim-lifecycle-parity xfail row added in #1018 had bug = "#1058". The other rows carry a tracker reference in that field, and a bare #1058 is ambiguous in the E2E report, which prints it on its own. This changes it to rocm-cli#1058, the same form the comments in nightly.yml, docs/testing.md and model_serving.feature already use. The bug field is a free-form string that nothing parses, so behaviour is unchanged.

CI-only/test-metadata change; no Gherkin scenario is affected, so none is added.

Verified: cargo test -p e2e-cucumber --lib passes (343).

The row's bug field was a bare #1058, unlike the other rows' tracker IDs and
ambiguous in a report. Use the same form as the comments that name the issue.

Signed-off-by: Tomas Saaristola <tsaarist@amd.com>
@tomastola
tomastola requested a review from a team as a code owner November 12, 2026 12:51
@tomastola
tomastola requested a review from r0x0r November 12, 2026 12:51
@github-actions

Copy link
Copy Markdown
Contributor
Security scan found no critical or high findings on lines changed by this pull request

View the security scan run for complete reports.

“New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta.

@juhovainio juhovainio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-line metadata change in expectations.toml (serve-27 xfail row: #1058 -> rocm-cli#1058). #1058 is open and matches the row's reason text (AIM stop failure on Strix Halo Ubuntu). No code or behavior change, no scenario needed, diff leak scan clean, CI has no failures so far (GPU lanes pending, consistent with the runner outage).

Not verified by me: the PR's claim that nothing parses bug.

@nowycondro nowycondro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — no blocking findings

Full review of the whole change (a one-line, single-file diff).
Follow-up to #1018; brings the bug field of the serve-aim-lifecycle-parity xfail row in expectations.toml from a bare #1058 to rocm-cli#1058, matching the form already used for this same issue in nightly.yml, docs/testing.md, and model_serving.feature.

Blocking

None

Non-blocking

None

Decisions for the author

None

Positive signals

  • The change is traced back to the actual consumer of the bug field (expectation.rs, where it's a plain String serialized as-is into the report) rather than assumed safe, which is exactly the right level of care for a one-line data-value edit in a file that's otherwise all data.

Deployment notes

None

What this covered

The full diff (b109db12…c4434b7, the single changed file tests/e2e-cucumber/expectations.toml), the full file's header/grammar comments, every reference to the bug field in tests/e2e-cucumber/src/expectation.rs, and a repo-wide search confirming rocm-cli#1058 is already the established form elsewhere for this exact issue. Also checked commit history/blame around the changed row and the file's own prior conventions for tracker references — one apparent precedent (a comment elsewhere in the file writing out ROCm/rocm-cli#897) turned out to be prose inside a comment, not a parallel bug = field value, so it isn't a comparable inconsistency and isn't reported as a finding.

All passes ran (code, agent-instruction adherence, history, prior-changes, code-comments). CI on the PR head shows all completed checks green; a few self-hosted E2E jobs were still queued/in-progress at review time, which is unrelated to this change (test metadata only, no behavior change). PR description and the linked issue (#1058, open, describing exactly the serve-aim-lifecycle-parity stop-not-confirmed symptom this row documents) both match the change accurately. Not reconciled against any discussion on the PR itself.

@tomastola

Copy link
Copy Markdown
Collaborator Author

Thanks both. On the one point juhovainio did not verify: bug is only stored and printed. In tests/e2e-cucumber/src/expectation.rs it is a plain String on XfailEntry, copied into the xfail expectation and shown in the report, and no code parses or validates its format (the one assertion on it, in a unit test, compares it to ROCMAI-898 for a different row). So the value change cannot alter behaviour. No code change needed; there were no open threads.

@tomastola
tomastola added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 986dd20 Nov 12, 2026
46 of 47 checks passed
@tomastola
tomastola deleted the ci/serve-27-xfail-bug-ref branch November 12, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants