Repository navigation
Conversation
…rt inputs Reads a finished run of the shared GPU queue (its per-lane results artifact and the run's job log) and writes each lane's report files where `cargo xtask e2e-report` reads them, named for the lane and the queue's gate, plus a status section for the top of the support matrix. Not wired in yet. Signed-off-by: Tomas Saaristola <Tomas.Saaristola@amd.com>
…ry ones out of the verdict The e2e report names a lane of the shared GPU queue by the lane (a queue MI300X lane is not the self-hosted one) and marks one the queue does not block on as advisory. release-readiness leaves advisory rows out of its failure count and still counts a blocking lane that came back with no result. Signed-off-by: Tomas Saaristola <Tomas.Saaristola@amd.com>
…se-readiness verdict e2e-report-nightly fetches the newest queue-run-results artifact of a main run that finished in the last 24 hours (and that run's job log, for the tested branch and each lane's gate), imports it with `cargo xtask e2e-queue-import` and opens the support matrix with a Queue lanes table. A missing, late or malformed queue run never fails the report: the page says so instead. Retiring the self-hosted R9700, MI350P and W7900 nightly lanes no longer drops them from the E2E-Support-Matrix and Release-Readiness wiki pages, and MI325X, MI350X and MI355X, which only the queue runs, are on them. Signed-off-by: Tomas Saaristola <Tomas.Saaristola@amd.com>
…'s lanes The import steps cannot fail the job, fetch by artifact name from a main run of this repository inside the 24 hour window, hold no credential beyond the job's read-only token, and run before the report is built. Signed-off-by: Tomas Saaristola <Tomas.Saaristola@amd.com>
Collaborator
Author
|
Closing: this logic now lives in #1063, the PR that retires the self-hosted lanes, so no PR leaves the wiki missing rows. 🤖 by agenthub on AMD AgentHub |
Contributor
Security scan found no critical or high findings on lines changed by this pull requestView the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
nightly.ymlbuilds the consolidated support matrix from thee2e-gpu-*-reportartifacts of its own lanes.publish-e2e-wikipushes it to theE2E-Support-Matrixwiki page, andrelease-readiness-nightly/publish-release-readiness-wikiderive theRelease-Readinesspage and its GO/NO-GO from it.The shared GPU queue nightly (
queue-run.yml, 02:17 UTC) publishes its results as onequeue-run-resultsartifact, which none of that reads. #1063 retires the self-hosted R9700, MI350P and W7900 nightly lanes in favour of the queue, so on its own it would drop those three GPUs from both wiki pages, and MI325X, MI350X and MI355X, which only the queue runs, would never appear.#1063 should merge only after this PR.
What
e2e-report-nightlynow also reads the queue's results:Fetch the latest queue results): the newestqueue-run-resultsartifact of a run on this repository'smainthat finished, and started, in the last 24 hours, whatever the run's conclusion was (a red lane fails the run but its artifact is still uploaded). It is found by the artifact's name, because the workflow contract forbids any other workflow naming the queue workflows or runner. The same run's job log is fetched too: it is the only place the queue prints which branch it tested and which lanes it blocks on.cargo xtask e2e-queue-import, new): copies each lane'sreport.json,platform.jsonandcommands.jsonlper channel toe2e-queue-<lane>[-advisory]-<channel>-report/, soe2e-reportrenders them with the other lanes. Nothing else of the artifact is copied (nolane.log, JUnit, HTML or harness diagnostics). Theplatform_slugis replaced byqueue-<lane>-<channel>, because queue lanes of different models report the same slug (the MI325X lane probes asmi300x, the MI350X and MI355X lanes asmi350p), which would fold them, and the self-hosted MI300X lane, into one grid column.MI325X (queue) Linux (release); a lane the queue marks advisory readsMI325X (queue, advisory) Linux (release).release-readinessleaves advisory queue rows out of its failure count. A blocking lane that came back with no result (or lacks a channel after not finishing cleanly) gets an empty report, shown asEMPTY, which already counts as a failure there.Queue lanestable (lane, GPU, gate, phase, exit status, channels reported).branchinput ofqueue-run.ymlcan), a download or log that fails, or an import that fails never fails the report. The page opens with a note saying that no queue lanes are in it tonight and why. Both new steps arecontinue-on-error.Public safety: the artifact is public and already scanned by the queue; only the three report files are used, and the only text taken from the job log (a public log) is the tested branch and commit and each lane's name, phase, exit status and gate, each checked against a strict pattern. A lane name that is not a plain lowercase word is shown as
unnamed-N, never echoed.Also:
descriptor.rsine2e-reportnames queue lanes and their gate; the docs (nightly-on-the-queue.md, a new section, andci-hardware-testing.md) andarchitecture.mdare updated;workflow_contractpins the new steps (continue-on-error, fetch filters, no credential beyond the job's read-only token, order, no dependency on the queue's workflows).On the real 2026-11-13 run (7 lanes) the import produces 13 report directories and a page with the seven lanes; the blocking
mi300x(failed suite, nightly channel left no report) andr9700s(no files came back) count towards NO-GO, the advisory lanes do not.Things to know
mi300xandr9700s, so including MI350P and W7900, which counted as failures when they ran self-hosted) no longer count towards the release-readiness verdict. That follows the queue's own gate, as asked; say if you would rather count them.Queue lanesnote is the only sign, so read it before reading a GO.nightly-queue.ymlis not imported.nightlydirectory carries a manifest that saysrelease, so it shows two(release)columns. That is what the lanes wrote, not something this changes.Not verified
main(publish-e2e-wikiandpublish-release-readiness-wikiare gated on it), so the end-to-end path, including the realgh run downloadand job-log fetch from a hosted runner, has not run. What was exercised: the importer ande2e-reporton the real artifact of the 11-13 run and its job log; the two shell steps run locally against a stand-ingh(newest-of-several selection, wrong branch / foreign repository / stale artifact skipped, stale start time, absent reasons, import failure fallback); the contract and unit tests. The first scheduled nightly after merge is the real test; the job'sactions: readpermission is already granted.e2e-queue-importreads (tested branch and commit, the lane matrix) are taken from one run's log; a change to the publisher's output format shows up as the "did not test main, or its job log could not be read" note, not as a wrong verdict.cargo test -p xtask: 872 pass, 1 fails here,smoke::tests::run_command_leaves_no_child_running_after_its_deadline, because the sandbox has nokillbinary; it is unrelated to this change.cargo clippy --workspace --all-targets -- -D warningsandcargo fmt --checkare clean.cargo test --workspace --all-targetsandcargo xtask smokewere not run.commit-signaturescheck cannot pass until they are re-signed.🤖 by agenthub on AMD AgentHub