Repository navigation
fix(lemonade): stop retrying a failed backend alignment on every install (ROCMAI-437) #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rominf
wants to merge
7
commits into
main
Choose a base branch
from
ROCMAI-437-fix-lemonade-alignment-retry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7f1ddf4
fix(lemonade): stop retrying a failed backend alignment on every inst…
rominf fd5954f
fix(lemonade): address review of the alignment failure record (ROCMAI…
rominf f50653f
test(lemonade): pin the alignment record's ordering and file name (RO…
rominf c059462
test(lemonade): name the tests behind the pinned --reinstall advice (…
rominf f247212
dev: run the lemonade tests when the e2e steps they read change (ROCM…
rominf b7e01d6
Merge remote-tracking branch 'origin/main' into ROCMAI-437-fix-lemona…
rominf 008ba67
fix(lemonade): name the recorded failure when a skipped alignment's i…
rominf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking:
cargo test -p rocm-engine-lemonade recordis advertised here as one of the "focused tests" for the alignment record, but cargo's test filter is an unanchored substring match, so this command also runs several unrelated tests whose names contain "record" elsewhere in the crate (e.g. install-footprint-record tests infootprint.rs, server-record tests indirect_llama.rs,record_runtime_version/prepare_embeddable_records_...ininstall.rs, and recording tests inlib.rs/router_serve.rs). It still runs the intended tests, just not only them, which undercuts the "focused" framing. A narrower filter (e.g.alignment_record::or the specific test-name prefixes already used on the next two lines) would make the claim accurate.Confidence 80 · documentation-accuracy