Repository navigation
ci: lint and test the rocm e2e-test-hooks build (ROCMAI-479) #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rominf
wants to merge
8
commits into
main
Choose a base branch
from
ROCMAI-479-ci-e2e-test-hooks-lint-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
78a280e
ci: lint and test the rocm e2e-test-hooks build (ROCMAI-479)
rominf d9c3617
fix(xtask): read the hooks contract's tokens from the parsed items, s…
rominf acaddf1
test(xtask): pin the hooks contract's scans and document where it run…
rominf 424307d
docs: say which CI jobs run the whole workspace's tests on a pull req…
rominf ab50d3e
docs: say the same about the whole-workspace jobs in the CI, pre-push…
rominf 39e69f2
docs(xtask): keep the pre-push banner comment and --help to what CI a…
rominf 23514a4
docs(xtask): say the pre-push --help CI claim holds for a pull reques…
rominf cf5bb84
fix(xtask): read the hooks seam scan through syn::parse_file and pin …
rominf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This re-runs the whole
rocmsuite feature-on in every test leg, which is about 1.5 min extra per leg. Fine if intended; the three feature-only tests could be selected with a filter, at the cost of a looser contract pin.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intended, so no code change. The whole
rocmsuite runs with the feature on because ungated code also behaves differently in that build (the hooks are compiled in and read environment variables), and that build is what the e2e lanes run. A-Efilter would silently drop a test gated on the feature later. The contract pins this exact command so that|| true,--no-runor a filter cannot satisfy it. The cost is about 1.5 min per test leg, inside the job's 20-minute timeout.