Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1321,6 +1321,25 @@ be, nothing is removed, so you can fix the cause and run `rocm uninstall` again.
Each step is reported as it finishes, so if a later step fails, the output
still shows what was already removed.

`rocm uninstall` stops any managed model server that is still running before it
removes anything, and also stops the background helper (`rocmd`), which is
force-stopped (on Linux its whole process tree, on Windows only the recorded
process) because it would otherwise restart the servers.
If a server cannot be stopped (or its service record cannot be read), the
command exits non-zero, leaves every file in place, and says what to repair or
stop by hand, so the tooling needed to stop it is never deleted out from under
a running server. A live server or helper recorded without a start time (written
by an older version) cannot be proven to be ours, so it is refused rather than
killed: stop it yourself, then re-run. The same refusal applies when the
helper's runtime state file cannot be read. The plan shows the refusal before
you confirm it. The stop pass is not atomic: if it aborts after stopping some
servers (or the helper), those stay stopped and their endpoint keys are gone;
the error names each one and the `rocm serve` command that brings it back. A
run that keeps the binaries and data (`--keep-binaries --keep-data`) leaves
running servers and the helper alone.
If a removal fails partway, the error lists what was removed and what is left,
because the binaries and service records may already be gone.

On Linux, if a config, data, or cache folder is a link to somewhere else (for
example a cache moved to a bigger disk), `rocm uninstall` removes the link and
leaves the folder it points to alone, whether or not the setting ends in a `/`.
Expand Down
1 change: 0 additions & 1 deletion apps/rocm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ libc.workspace = true
[target.'cfg(windows)'.dependencies]
self-replace = "1.5"
windows-native-keyring-store = "1.1"
windows-sys = { version = "0.61", features = ["Win32_Storage_FileSystem"] }

[target.'cfg(target_os = "macos")'.dependencies]
apple-native-keyring-store = { version = "1.0", features = ["keychain"] }
Expand Down
1 change: 1 addition & 0 deletions apps/rocm/src/automations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,7 @@ mod tests {
running: true,
automations_enabled: true,
daemon_pid: 123,
daemon_start_ticks: None,
started_at_unix_ms: 1,
last_tick_unix_ms: 2,
local_webhook_endpoint: Some("http://127.0.0.1:19191/automation-events".to_owned()),
Expand Down
2 changes: 1 addition & 1 deletion apps/rocm/src/chat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ fn chat_tool_call_display_label(call: &providers::ChatToolCall) -> String {
}
}

fn loopback_tcp_port_is_reachable(host: &str, port: u16) -> bool {
pub(crate) fn loopback_tcp_port_is_reachable(host: &str, port: u16) -> bool {
let Ok(addresses) = (host, port).to_socket_addrs() else {
return false;
};
Expand Down
Loading
Loading