Skip to content

docs(dash,xtask): remove doc pointers to documents that never existed and gate against new ones - #371

Closed
siloteemu wants to merge 11 commits into
mainfrom
fix/dash-dangling-doc-pointers
Closed

siloteemu wants to merge 11 commits into
mainfrom
fix/dash-dangling-doc-pointers

Conversation

@siloteemu

@siloteemu siloteemu commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Module-level doc comments across the rocm-dash crates sent readers to 18
../wiki/… markdown paths in 14 files. No wiki/ directory has ever existed
in this repository or anywhere in its history, and the repository has no GitHub
wiki, so none of the 14 cited documents could ever be opened. The paths were
mutually inconsistent about depth (../, ../../, ../../../) and all sat
inside backticks, so none of them ever rendered as a link either.

These pointers sat on the modules carrying the least obvious design — the
state reducer, the metric registry, the benchmark result schema, GPU partition
modes — so the reader was sent away exactly where the explanation was most
needed.

Each pointer is either removed or replaced with a short explanation written in
the file, since none of the cited content exists anywhere to link to instead.
Three further citations of the same class are fixed here as well: a bare
rocm-cli-unification-working-agreements.md, which is equally unresolvable,
and two pointers that cited line ranges in other files which had already
drifted onto unrelated code.

To stop the pattern returning, cargo xtask verify-doc-paths scans //! and
/// lines in tracked .rs files for .md citations and resolves each one
against the citing file's directory or the workspace root, reporting every
violation in a single run. It ignores URLs, non-doc-comment lines and ////
banner comments so that string literals and build-artifact paths are not
flagged. It is wired into the existing clippy job, and **/*.md was added to
the rust path filter so that deleting a cited markdown file also runs the
check.

Verification

  • cargo xtask verify-doc-paths — 16 citation(s) across 188 file(s) resolve
  • Confirmed the gate catches the real defect: reintroducing one of the removed
    citations fails the check and names the file and line; reverting it passes.
  • Each guard in the checker was mutation-tested individually — neutering it
    must fail a named test — so the unit tests cannot pass for the wrong reason.
  • cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace --all-targets, cargo test --workspace --doc, hawkeye check, prek run --all-files, python scripts/smoke_local.py — all pass.

No acceptance scenario accompanies this change: it alters documentation text
and adds a build-time consistency check, and changes no runtime behaviour. The
new check is covered by unit tests in xtask/src/doc_paths.rs.

  • If this PR fixes a bug, searched tests/e2e-cucumber/expectations.toml for the fixed ticket ID and removed/narrowed any now-stale xfail rows.

Not applicable — this changes no runtime behaviour, and no xfail rows relate to it.

Module docs cited 18 `../wiki/…` markdown paths across 14 files. No
`wiki/` directory has ever existed in the tree or anywhere in git
history, and the project has no GitHub wiki. The paths were also
mutually inconsistent about depth (`../`, `../../`, `../../../`), and
every one sat inside backticks, so none of them ever rendered as a link
even where a target might have existed.

None of the 14 cited documents exists anywhere, so each pointer is
either removed or replaced with a short explanation inline in the file
it was meant to send the reader away from.

One further citation of the same class, a bare
`rocm-cli-unification-working-agreements.md`, was equally unresolvable
and is fixed here too.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
`cargo xtask verify-doc-paths` scans `//!` and `///` lines in tracked
`.rs` files for citations of `.md` files and resolves each one against
the citing file's own directory or the workspace root, both of which
this tree uses. Every violation is reported at once rather than only
the first.

The check runs in the existing `clippy` CI job. `**/*.md` joins the
`rust` path filter so that deleting or renaming a cited markdown file
also triggers it, even when the change touches no `.rs` file.

URLs and lines outside doc comments are deliberately ignored: ordinary
code names `.md` files legitimately in string literals, and flagging
those would make the check unusable.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
`cargo xtask verify-doc-paths` failed on the file that implements it. The
scan is line-based, and the test fixtures were multi-line string literals
joined with a trailing backslash, so each continuation line began with
`//!` or `///` once its indentation was trimmed. Two lines of fixture data
— paths chosen precisely because they resolve to nothing — were read as
real citations on `doc_paths.rs` itself.

Building the fixtures with `concat!` keeps the prefix off the start of a
line and leaves what each test asserts untouched. The paths they carry are
now neutral placeholders: the check's acceptance criterion is that no
`.rs` file in the tree names the directory that motivated it, and a test
fixture is no exception. Both unresolvable shapes are still covered, the
`../`-prefixed form and the bare filename.

A design note records the limitation, since the same shape can bite a doc
comment that quotes source or holds a fenced code block.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
`resolve` joined the candidate onto both the citing file's directory and
the workspace root and asked the filesystem, so a `../`-prefixed citation
could climb out of the checkout and match a file in a sibling directory.
Whether such a directory exists is a property of one machine, not of the
tree: the same citation would resolve on the author's disk and dangle in
CI, and the shape that motivated this check is exactly the one that
escapes.

Both candidates are now normalized lexically — `canonicalize` is no use
on paths that do not exist — and rejected unless they land inside the
workspace root.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
The module doc said rows are grouped by `(cell, model, backend,
concurrency)`. `RollupKey` also holds `tp` and `dtype`, and the field is
`engine`, not `backend` — a difference the reader would only find by
disbelieving the doc, and one that misstates what Pass^N and Pass@N are
computed over.

`row_verdict`'s summary is also split into a real first sentence. The
paragraph break existed only to satisfy `too_long_first_doc_paragraph`,
which left rustdoc showing half a sentence as the item's summary.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
The module doc said the trial-group key is "every field that defines the
run except the trial itself". It is not: `BenchmarkRow` also carries
`task`, `prompt_class`, `pp`, `max_num_seqs`, `attention_backend`,
`kv_dtype`, `spec`, `input_len`, `output_len` and `cache_mode`, none of
which `RollupKey` holds. Two rows that differ only in `input_len` are
folded into one trial set, so the sentence promised a guarantee the code
does not make.

`RollupKey`'s own doc carried the same overreach from further back —
"everything that defines the backend config is held fixed" — while
`endpoint`, `pp`, `max_num_seqs`, `attention_backend`, `kv_dtype` and
`spec` sit in the schema's backend-config block and outside the key. Both
now state the key and say plainly what it does not separate.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
Two doc comments pointed at a line range in another file. Both had
already rotted: `agent.rs:59-62` lands on `InferenceParams`' sampling
knobs rather than the read-only chat seam it names, and
`runner.rs:446-460` on nothing in particular — the
`known_services.difference(&disc.seen)` it cites now sits near line 519.

A line range is a citation that decays on the next edit above it, which
is the same failure this branch is removing elsewhere, so both now name
the file and the symbol and leave the reader to grep.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
`**/*.md` joined the `rust` filter so a deleted or renamed doc file
reaches `cargo xtask verify-doc-paths`. dorny/paths-filter matches
patterns with picomatch, where a leading `**/` also matches zero
directories, so the glob already covers the root-level `MANIFEST.md`
entry sitting above it. Keeping both left a rule that can never decide
anything, and two comments where one states why markdown is a Rust
input at all.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
`"////foo".strip_prefix("///")` succeeds, so a four-slash separator
banner was scanned like a doc line. rustc treats `////` as an ordinary
comment and rustdoc renders nothing from it, so a file name inside one is
not a citation the reader can follow, and flagging it would fail CI over
text no document ever pointed at.

None exists in the tree today, which is why the gate stayed green. The
design note also records that the block forms `/*! … */` and `/** … */`
are not scanned at all.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
Two tests passed for the wrong reason. `ignores_urls_ending_in_md` used
only `scheme://host` links, where the scheme's `//` leads the character
run and the absolute-path guard rejects the candidate on its own — the
URL filter could be deleted and the test would still be green. It now
also carries an anchored link, whose fragment puts a bare relative path
inside the token, so dropping the whole token is what keeps the line
quiet.

`flags_every_unresolvable_citation_not_just_the_first` re-implemented the
collection loop with an iterator instead of calling the code that does
it, so `run()` could have returned at the first miss and the test would
not have noticed. The loop moves into `check_source`, which returns the
citations checked and a violation line for each miss; the test now covers
both the count and the rendered messages, and `run()` keeps its totals.

Verified by mutation: neutering the URL filter or capping the collection
at one now fails the matching test.

A design note records what the URL filter does not cover — a link
written without a scheme, and a citation glued to a URL with no space.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
Mutating each guard in `candidates_in_line` and deleting it showed two
that no test noticed. Removing the angle brackets from the placeholder
delimiter set left every test green, because the only bracketed fixture
(`<name>.md`) has an empty stem and is rejected by the stem check first.
Removing the stem check left every test green in turn, because that same
fixture is rejected by the delimiter check. Each guard was standing in
for the other, so either could have been deleted unnoticed.

Add a bracketed name with a real stem, and a bare extension with nothing
next to it, so each guard is now the only thing rejecting one case.

Signed-off-by: Teemu Kuusisto <teemu.kuusisto@amd.com>
@siloteemu
siloteemu marked this pull request as ready for review September 9, 2026 19:29
@siloteemu
siloteemu requested a review from a team as a code owner September 9, 2026 19:29
@siloteemu
siloteemu requested a review from r0x0r September 9, 2026 19:29
@juhovainio

Copy link
Copy Markdown
Collaborator

Reviewed the full diff, including the new xtask/src/doc_paths.rs checker (the actual logic here, not just doc edits). No issues.

The checker's design holds up: doc-line-only scanning (skips //// banners and ordinary code), URL stripping by whole token, the two resolution roots (relative-to-file vs. workspace-root), and the workspace-escape guard (path.starts_with(root) after a filesystem-free ./.. normalization) are all correct and each has a dedicated test, including the two trickiest cases — a citation with no scheme that could be mistaken for a real path, and a path that climbs out of the workspace but happens to exist on the author's disk. Walked through the placeholder-adjacency logic ({name}.md, <name>.md) by hand and it does what it claims.

The replaced doc comments read as genuine explanations where one was warranted (the Elm-style reducer note in rocm-dash-core/src/lib.rs is a real improvement, not padding) and clean removals elsewhere. Also correctly drops the two stale line-range citations (runner.rs:446-460, agent.rs:59-62) down to bare filenames, since a line range would just go stale again and the new checker only validates file existence.

CI is green. Looks safe to approve.

@juhovainio juhovainio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new xtask/src/doc_paths.rs checker as real logic, not just a doc change: the doc-line-only scanning, URL stripping, the two resolution roots (relative-to-file vs. workspace-root), and the workspace-escape guard are all correct, and each tricky case (a citation with no URL scheme, a path that climbs out of the workspace but exists on the author's disk) has a dedicated test. The replaced doc comments read as genuine explanations or clean removals. CI is green. Approving.

@nowycondro nowycondro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Automated review · pr-review-watcher · a7ad926

Review — no blocking findings

Full review of the whole change.
No ticket named. No runtime behavior changes; the description's claims (18 dead ../wiki/... pointers across 14 files, 3 further citations of the same class, the new cargo xtask verify-doc-paths gate and its scan rules) all match what the review found in the diff — no mismatch.

Blocking

None

Non-blocking

None

Decisions for the author

  • Widening the rust CI path filter to **/*.md — tradeoff. This makes any PR that touches any markdown file anywhere in the repo trigger the full clippy job (previously only MANIFEST.md did), which is necessary for soundness — deleting/renaming a cited .md file with no .rs file in the diff must still run verify-doc-paths — but is a real CI-cost increase for prose-only PRs. Already deliberate and documented in the workflow comment; worth confirming the cost is acceptable going forward.
  • Documented URL-handling limitation in doc_paths.rs — tradeoff. The module doc itself notes two unhandled shapes: a scheme-bearing link glued with no space to an adjacent real citation (drops both), and a scheme-less bare host/path (not filtered, could misread as a local citation if one ever appeared). Neither shape currently exists in the tree; both are explicitly called out as accepted limitations rather than silently missed. Non-blocking as written.

Positive signals

  • bench_rollup.rs's rewritten grouping-key doc comment, (cell, model, engine, tp, dtype, concurrency), is byte-for-byte correct against the real RollupKey struct — and is a genuine accuracy fix, not just dead-link removal: the old wiki-citation text it replaced had named a nonexistent backend field and omitted tp/dtype.
  • lib.rs's new "Elm-style reducer" description was checked against state::State::apply's actual signature and the StateEvent/SideEffect types it names — matches exactly.
  • doc_paths.rs's workspace-escape guard uses component-wise Path::starts_with rather than a raw string prefix check, correctly avoiding the classic bug where a sibling directory name sharing a prefix (e.g. /root2 vs /root) would otherwise wrongly pass containment.
  • Every guard in the new checker is backed by a test that was independently confirmed (via targeted mutation of each branch) to fail when that specific branch is neutered — including two guards the author's own later commits (5909e8c8, a7ad9267) found and fixed were previously untested, a rare case of a PR's own history showing self-driven mutation-coverage work.
  • The approval.rs doc-comment edit also removed a second, non-wiki/ dangling citation (rocm-cli-unification-working-agreements.md) beyond the PR's stated scope — confirmed that file has never existed in the repo's history — showing good impact-analysis instinct rather than a narrow literal fix.

Deployment notes

None — documentation and a new build-time CI gate only; no runtime behavior changes.

What this covered

Full change reviewed completely (merge-base 03c46b58 … head a7ad9267), split across two independent parallel passes: (1) the new xtask/src/doc_paths.rs checker plus its xtask/src/main.rs and .github/workflows/ci.yml wiring, and (2) all 16 touched crates/rocm-dash-* doc-comment-only files, each read in full at the PR head via git show (never checked out). Both passes independently verified every rewritten doc comment against the real code it describes, checked for orphaned/incomplete edits, and ran mutation-style verification confirming each new test actually depends on the logic it claims to cover. Driver-level checks on top: full commit-message/structure review (11 atomic, Conventional-Commits-compliant commits, each independently verifiable against its own stated rationale), a repository-wide search confirming zero remaining wiki/ references of any kind in any file type, cross-check of the PR description against the diff (no scope mismatch), and a live re-check of PR state immediately before publishing (head commit unchanged, CI fully green, no prior review from this account).

Did not run: a separate history/blame pass beyond what full-file reads and commit-message review already covered (doc_paths.rs is new, so there is no prior history to blame; the edited doc comments were read in full file context). No Rust toolchain was available in the review sandbox, so the checker's logic was independently verified by porting it to Python and executing targeted mutations rather than running cargo test directly — note this is a substitute verification, not identical to running the real suite, though the PR's own CI already ran the genuine cargo test / cargo xtask verify-doc-paths and is green. Not reconciled against any PR discussion or review threads, per scope — only checked that no up-to-date review from this reviewing account already existed at the current head (none found).

@juhovainio juhovainio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(cat /tmp/review_body.md)

Comment thread xtask/src/doc_paths.rs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: missing docs/architecture.md entry for this new file.

AGENTS.md §5/§6 requires every .rs file under xtask/src to get an inline markdown row in docs/architecture.md "in the same change as the file," enforced by cargo xtask check-architecture-doc in the clippy CI job. I read that checker's source on current origin/main directly: doc_paths.rs falls inside its HAND_KEPT_TREES scope (xtask/src/) with no helper exemption, and docs/architecture.md on current main has no row for it (it would sit alphabetically between demos.rs and e2e.rs, and isn't there).

This PR's own CI passed only because its branch point (merge-base 03c46b58, 2026-09-09) predates this enforcement script existing on main — origin/main has since advanced well past it, and git merge-tree shows this branch is no longer cleanly mergeable regardless (real conflicts in ci.yml, amd_smi.rs, bench_rollup.rs, lib.rs, approval.rs, plus a modify/delete conflict on vllm_log.rs, deleted on main). Whoever rebases this will hit a real clippy-job failure unless a docs/architecture.md row is added for this file in the same change.

Confidence 85 · mechanical · Fix: add the docs/architecture.md row alongside the rebase this branch needs anyway.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to the guard, which is being dropped; see the closing comment on the PR.

@juhovainio

Copy link
Copy Markdown
Collaborator

Correction to the review above (pullrequestreview-5939042284): a templating error posted that review's body as the literal unexpanded string $(cat /tmp/review_body.md) instead of the actual report. There is no tool available here to edit a submitted review's body, so this comment supersedes it with the intended content. The CHANGES_REQUESTED verdict stands as submitted.


Review — needs work

Full review of the whole change (single-context; see What this covered for why the planned fan-out didn't run).
No ticket named. Description is precise and matches the diff exactly: 18 ../wiki/... citations across the same 14 files it names, plus the 3 additional citations (rocm-cli-unification-working-agreements.md, agent.rs:59-62, runner.rs:446-460) it separately calls out — no scope mismatch in either direction.

Blocking

  • New xtask/src/doc_paths.rs has no entry in docs/architecture.md — xtask/src/doc_paths.rs:1 (new file)
    The repo's own convention (AGENTS.md §5/§6) requires every .rs file under xtask/src to be cited by an inline markdown link in docs/architecture.md, "in the same change as the file," with no exemption. This is mechanically enforced by cargo xtask check-architecture-doc (xtask/src/architecture_doc.rs, read in full at current origin/main) as part of the clippy CI job. I confirmed directly: in_hand_kept_scope("xtask/src/doc_paths.rs") matches HAND_KEPT_TREES = ["xtask/src/", ...] with no helper exemption for that tree, and docs/architecture.md on current main has no row for doc_paths.rs (it would sit alphabetically between demos.rs and e2e.rs, and isn't there). This PR's own CI ran green only because its branch point (merge-base 03c46b58, from 2026-09-09) predates both this enforcement script and the file it would need to cite — origin/main has since advanced far past it (confirmed via git merge-tree, which also surfaces real content conflicts in .github/workflows/ci.yml, amd_smi.rs, bench_rollup.rs, lib.rs, approval.rs, and a modify/delete conflict on vllm_log.rs, deleted on main). Whoever rebases this will hit a real, currently-enforced clippy-job failure unless a row is added.
    Confidence 85 · mechanical · Fix: add a docs/architecture.md row for xtask/src/doc_paths.rs in the same change (alongside the rebase this branch needs regardless).

Non-blocking

None

Decisions for the author

  • discover_rust_files's third_party/ exclusion is untested — non-blocking-improvement
    !line.starts_with("third_party/") only strips a root-level third_party/ directory, not a nested one (e.g. engines/foo/third_party/bar.rs), and no test exercises this filter at all (it isn't unit-tested the way every other guard in the file is — it shells out to git ls-files, which is harder to fixture). No such nested directory currently exists in the tree, so this has no live impact today, but it's worth a test (or a scope note) if a vendored third_party/ subtree is ever nested rather than top-level.
  • Widening the rust CI path filter to **/*.md — tradeoff (already called out in the workflow comment itself: any PR touching any markdown file now triggers the full clippy job, which is necessary so that deleting/renaming a cited .md file with no .rs change still runs verify-doc-paths, at the cost of CI time on prose-only PRs). Confirmed sound as written; flagging only so it's visibly re-confirmed here too.

Positive signals

  • bench_rollup.rs's rewritten RollupKey doc comment — (cell, model, engine, tp, dtype, concurrency) — is byte-for-byte correct against the real struct fields and order, read in full; the old wiki-citation text it replaced had named a nonexistent backend field and omitted tp/dtype, so this is a genuine accuracy fix, not just a dead-link removal.
  • Removing the stale runner.rs:446-460 line-range citation in telemetry_contract.rs (replaced with a bare runner.rs reference) is verified correct: the real known_services.difference(&disc.seen) / InstanceGone logic now lives at lines 519/528, well outside the old cited range — the edit fixes a citation that had already drifted, and the bare-filename form can't drift the same way again.
  • xtask/src/doc_paths.rs's workspace-escape guard (normalize() + path.starts_with(root)) is sound: PathBuf::starts_with compares components, not raw strings, and I traced a ..-climbing candidate through normalize() by hand — when it climbs past the available components it leaves a literal .. segment in the normalized path, which correctly fails starts_with(root) rather than falsely matching a sibling directory with a shared string prefix.
  • A full-repo git grep at the PR head confirms zero remaining wiki/ references and zero remaining rocm-cli-unification-working-agreements references of any kind — the stated cleanup is actually complete.

Deployment notes

This branch is roughly two months stale against origin/main (merge-base 03c46b58, from 2026-09-09) and GitHub reports mergeable_state: dirty. A read-only git merge-tree against current main shows real content conflicts in .github/workflows/ci.yml, crates/rocm-dash-collectors/src/amd_smi.rs, crates/rocm-dash-core/src/bench_rollup.rs, crates/rocm-dash-core/src/lib.rs, and crates/rocm-dash-tui/src/ui/approval.rs, plus a modify/delete conflict on crates/rocm-dash-collectors/src/vllm_log.rs (deleted on main since this branch forked). None of that is a defect in this diff's own content, but it means a plain merge isn't currently possible, and the rebase needed to resolve it is also the natural place to add the docs/architecture.md row above.

What this covered

Every changed file read in full at the PR head (03c46b581a01349bb34c3120e7ac9983c0f74587...a7ad92676b59c2dd2b6415789bfe77bb338916b1, diff hash 524cbbfeb925): xtask/src/doc_paths.rs (new, 413 lines) traced by hand through its path-matching, normalization and workspace-escape logic against its own tests; xtask/src/main.rs and .github/workflows/ci.yml wiring cross-checked against sibling commands (verify-pinned-keys, verify-commits) for the kebab-case subcommand naming and CI step placement/gating; all 14 doc-comment-only files read completely, each factual claim in a changed/added doc line checked against the real code or sibling file it describes. CI: all 26 check runs completed with success conclusion.

Did not run as an independent fan-out: the review-code skill calls for splitting this into per-group worker passes, but every Agent spawn attempt failed with "concurrent subagent limit reached" (a shared pool already at its cap from unrelated work), even after a wait and retry. This review proceeded single-context instead — coverage is therefore narrower than the method's target (measured 12–30% of a fan-out's yield for a single pass), though the subject here is small (19 files, +454/−30) and every file was still read in full rather than skimmed. Did not run: a dedicated git-blame/history pass beyond what was needed to confirm specific citations (doc_paths.rs is new, so has no prior history; the touched doc comments' history wasn't separately mined beyond confirming the cited line ranges had drifted); a "prior changes" pass (no earlier review of these specific files was available to check for recurring comments). Not reconciled against the PR's two existing reviews as instructed — their content was unavoidably visible while checking PR/review state before this pass began, but every finding above was independently re-derived from the code itself (the RollupKey field match, the State::apply signature, the runner.rs line numbers, and the docs/architecture.md gap — the last of which neither existing review raised) rather than taken from what either said.


🤖 Automated by an AI agent

@siloteemu

Copy link
Copy Markdown
Contributor Author

Closing this one. The dangling ../wiki/ references it set out to fix were removed from main by #978, so the doc-comment edits here are no longer needed.

What remains is the cargo xtask verify-doc-paths guard. Keeping it would mean maintaining a hand-rolled citation scanner of the kind #582 deleted in favour of lychee, and it would widen the rust CI path filter to every Markdown file. That is more cost than a one-time cleanup justifies, so I am not carrying it.

Thank you juhovainio for the careful review. The points raised (the missing docs/architecture.md row, the cost of the **/*.md filter, and the untested third_party/ exclusion) all concern the guard and are moot now that it is dropped. I have left the review threads as they are.

Happy to revisit if the pattern comes back. The branch is left in place.

@siloteemu siloteemu closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants