Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/rocm/src/comfyui.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4993,13 +4993,13 @@ mod archive_properties {
/// of the app root, and the very next install step creates `models/`
/// through it. Minimal shrunk counterexample: one entry, `l -> ..`.
#[test]
#[ignore = "known defect: a top-level symlink in the source archive becomes the install's source dir (#522)"]
#[ignore = "known gap: a top-level symlink in the source archive becomes the install's source dir (#522)"]
fn source_unpack_never_writes_outside_the_app_root() {
property("comfyui", entries(), ESCAPES_ONLY, false).unwrap();
}

#[test]
#[ignore = "known defect: a top-level symlink in the source archive becomes the install's source dir (#522)"]
#[ignore = "known gap: a top-level symlink in the source archive becomes the install's source dir (#522)"]
fn installed_source_path_is_a_real_directory() {
property("comfyui-source-dir", entries(), ESCAPES_ONLY, true).unwrap();
}
Expand Down Expand Up @@ -5029,7 +5029,7 @@ mod archive_properties {
/// first install write, nothing may exist under `outside/` and `source`
/// must be a real directory.
#[test]
#[ignore = "known defect: a top-level symlink in the source archive becomes the install's source dir (#522)"]
#[ignore = "known gap: a top-level symlink in the source archive becomes the install's source dir (#522)"]
fn top_level_symlink_in_source_archive_does_not_redirect_the_install() {
use crate::archive_props::{OUTSIDE_TOKEN, concretize};
let layout = Layout::new();
Expand Down
10 changes: 4 additions & 6 deletions apps/rocm/src/deletion_properties.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,10 @@ impl Reach {
}
}

/// 256 by default; `ROCM_DELETION_PROP_CASES` raises it for a deeper local run.
/// 256 by default; `ROCM_DELETION_PROP_CASES` raises it for a deeper local
/// run, and is ignored when it is lower.
fn case_count() -> u32 {
std::env::var("ROCM_DELETION_PROP_CASES")
.ok()
.and_then(|value| value.parse().ok())
.unwrap_or(256)
crate::test_support::case_count_from_env("ROCM_DELETION_PROP_CASES", 256)
}

fn report_reach(name: &str, reach: &Mutex<Reach>) {
Expand Down Expand Up @@ -826,7 +824,7 @@ fn uninstall_removes_exactly_what_the_review_lists() {
/// however spelled, is only unlinked). Shrinks to one root naming `$HOME`.
/// Tracked in #531; un-ignore this when that guard lands.
#[test]
#[ignore = "finding: rocm uninstall applies no guard to config/data/cache roots (#531)"]
#[ignore = "known gap: rocm uninstall applies no guard to config/data/cache roots (#531)"]
fn uninstall_never_deletes_a_folder_rocm_cli_did_not_create() {
if let Err(error) = run_uninstall_property(case_count(), true) {
panic!("{error}");
Expand Down
6 changes: 6 additions & 0 deletions apps/rocm/src/gpu_policy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -981,6 +981,12 @@ pub(crate) fn detect_gpu_count() -> Option<usize> {
if count == 0 { None } else { Some(count) }
}

/// Property tests for `--gpu` selection; a child module so it can reach the
/// private selection functions above.
#[cfg(test)]
#[path = "gpu_selection_proptests.rs"]
mod gpu_selection_proptests;

#[cfg(test)]
mod tests {
use std::time::Duration;
Expand Down
Loading
Loading