Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
9105d5a
fix: make the command preview denote the argv it runs
rominf Oct 5, 2026
b6aa166
test(shell_quote): check the rendered argv against a real sh
rominf Oct 5, 2026
76343cc
test(dash-tui): check approval previews against a real sh
rominf Oct 5, 2026
fbe4410
docs(shell_quote): PowerShell does not read '\'' as a quote
rominf Oct 5, 2026
bd2e40c
test(chat): pin the planner-note filter; make the path_exists check f…
rominf Oct 5, 2026
3b19bfb
style: rustfmt the new preview tests
rominf Oct 5, 2026
dca0e18
test(e2e): a request plan names a quoted folder as one argument
rominf Oct 14, 2026
e55c5e7
test(e2e): the dry-run command line keeps a quoted folder whole
rominf Oct 5, 2026
fd057e3
docs(architecture): list shell_quote.rs among the shared CLI-output c…
rominf Oct 5, 2026
08677e9
style: rustfmt the dash preview tests after the rebase onto #500
rominf Oct 5, 2026
ef23138
test: ask /bin/sh by absolute path in the real-shell quoting tests
rominf Oct 5, 2026
0a7e620
docs(shell_quote): say why `=` may stay bare, and where it may not
rominf Oct 9, 2026
520763e
fix: quote the service and runtime hints added on main meanwhile
rominf Oct 13, 2026
2dafca3
refactor: share one shell quoter between the CLI and the dash
rominf Oct 13, 2026
28700a7
fix(chat): screen every tool call, and every value a refusal echoes
rominf Oct 13, 2026
2d2e917
fix(comfyui): quote the runtime key in the install it says will finish
rominf Oct 14, 2026
8486fcb
refactor(shell_quote): use the shared line-separator predicate
rominf Oct 16, 2026
c489a0e
fix(dash): quote the service id in the quit prompt's stop commands
rominf Oct 17, 2026
d1c46c6
test: keep the advised-command checker in step with the quoted hints
rominf Oct 26, 2026
7486c04
refactor(shell_quote): use rocm-core's POSIX quoter, pinned to the da…
rominf Nov 3, 2026
c20a867
fix(services): quote the id in the `rocm services logs` lines the lis…
rominf Nov 3, 2026
b9614ca
refactor(therock): call shell_quote directly for the dry-run command …
rominf Nov 3, 2026
7c40fd0
test(e2e): describe the dash's single-quoted `--root` preview
rominf Nov 3, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ semver = "1.0"
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
sha2 = { version = "0.10", features = ["oid"] }
# Test-only. The oracle the command-preview property tests check against: it
# splits a rendered command line the way a POSIX shell word-splitter does, so
# "the preview denotes the argv that runs" becomes a mechanically checkable
# round-trip rather than a human reading.
shlex = "2"
# `linux-tmpfs` makes tmpfs mounts visible to the free-space preflight, so a
# cache or install root under a tmpfs `/tmp` (the Fedora and Arch default)
# reports its real size instead of being invisible. `linux-netdevs` is
Expand Down
1 change: 1 addition & 0 deletions apps/rocm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,4 @@ zbus-secret-service-keyring-store = { version = "1.0", features = ["rt-tokio-cry
# Also used for the recursive-deletion paths in deletion_properties.
proptest = { version = "1", default-features = false, features = ["std"] }
tempfile = "3"
shlex.workspace = true
2 changes: 1 addition & 1 deletion apps/rocm/src/advised_commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,7 @@ const NOT_INVOCATIONS: &[(&str, &str, &str)] = &[
),
(
"apps/rocm/src/service_hints.rs",
"rocm services {action} {service_id} --yes",
"rocm services {action} {} --yes",
"the verb is a format argument; every value it takes is checked against the \
real hint by `service_action_retry_advice_parses_for_generated_ids` (the \
`run_approved_service_action` verbs) and `every_service_action_hint_verb_parses` \
Expand Down
Loading
Loading