Repository navigation
ROCMAI-826: keep the cache folder under an overridden data folder #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1287,7 +1287,12 @@ you pass `--yes`. Each `--keep-*` flag skips the removal of one category: | |
| the managed `uv` package cache, which `--keep-data` controls. | ||
|
|
||
| By default, the configuration and data directories are both `~/.rocm`, and the | ||
| cache directory is `~/.rocm/cache`. `uninstall` removes a category's directory | ||
| cache directory is `~/.rocm/cache`. The `ROCM_CLI_CONFIG_DIR`, | ||
| `ROCM_CLI_DATA_DIR`, and `ROCM_CLI_CACHE_DIR` environment variables move them; | ||
| when only `ROCM_CLI_DATA_DIR` is set, the cache directory moves with it, to | ||
| `<data directory>/cache`. A cache that an earlier version kept at `~/.rocm/cache` | ||
| while only `ROCM_CLI_DATA_DIR` was set is no longer used or removed by `rocm | ||
| uninstall`; delete it by hand if you don't need it. `uninstall` removes a category's directory | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The inline code span |
||
| unless you keep that category, so on a default installation a flag doesn't | ||
| protect its files by itself. To keep your settings and data, pass `--keep-config` | ||
| and `--keep-data` together. Run with `--dry-run` first to confirm what is kept. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also check docs/testing.md, docs/manual-testing.md and the storage/uninstall
--helptext for the old "cache is always~/.rocm/cache" claim and update them in this change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked docs/testing.md, docs/manual-testing.md and the
storage/uninstall --keep-cachehelp text for a claim that the cache is always~/.rocm/cache: none makes it. Both docs set all threeROCM_CLI_*_DIRvariables explicitly, which stays correct, and the help text only says "the cache directory". The README paragraph is the one place that stated the location, so it is the only doc changed; the PR description now says this.