Repository navigation
fix(lemonade): pin Lemonade 2026.44.1 so a ROCm 10.1 SDK gets a ROCm backend #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5920576
fb07c90
a7c305c
a6adb69
202490c
0b2add5
3ab5ec0
65c9bc8
96956bf
c03c7b0
2a6520a
9764b29
ff1673d
9605dbb
3779afb
391bea4
9ee7338
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,10 +46,22 @@ serving is Linux or WSL2 only (see [docs/vllm.md](docs/vllm.md)). | |
|
|
||
| The minimum supported Linux release, native or under WSL2, is Ubuntu 24.04. On | ||
| other distributions the equivalent requirement is glibc 2.38 with | ||
| `GLIBCXX_3.4.32`: that is what the Lemonade engine is linked against, and every | ||
| published build of it needs those versions, so there is no older release to fall | ||
| back to. Ubuntu 22.04 ships glibc 2.35 and cannot run it; Ubuntu 24.04 provides | ||
| glibc 2.39 and `GLIBCXX_3.4.33`. | ||
| `GLIBCXX_3.4.32`, and OpenSSL 3.0.0 or newer (`libssl.so.3`): that is what the | ||
| Lemonade engine is linked against. Every stable Lemonade release from 11.5.1 | ||
| through 2026.44.1, the one rocm-cli pins, needs those versions; the newest, | ||
| 2026.45.3, needs glibc 2.43 and OpenSSL 3.2.0, which is why it is not pinned. | ||
| Ubuntu 22.04 ships glibc 2.35 and cannot run it; Ubuntu 24.04 provides glibc | ||
| 2.39, `GLIBCXX_3.4.33` and OpenSSL 3.0.13. On an older host, | ||
| `rocm engines install lemonade` stops before downloading anything and says what | ||
| falls short: the glibc version Lemonade needs and the newest the host's | ||
| `libc.so.6` provides, or that | ||
| the host has no `libssl.so.3`, the library of OpenSSL 3. That check reads glibc | ||
| and OpenSSL only; `GLIBCXX_3.4.32` (libstdc++) is not checked. Where Lemonade is | ||
| already installed, the same check refuses to reinstall it or start it, and says | ||
| the installed copy was left as it is. The check reads the `ldconfig` cache, so a | ||
| host that provides these libraries some other way (`LD_LIBRARY_PATH`, a Nix or | ||
| Guix profile) can set `ROCM_CLI_DISABLE_LEMONADE_HOST_LIBRARY_CHECK=1`: the | ||
| shortfall is then printed as a warning and Lemonade goes ahead. | ||
|
|
||
| > [!IMPORTANT] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The claim that the message names the OpenSSL version "the host has" is not reachable on a pre-3.x host with the real probe (see the comment in
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in a6adb69. The README now says what the probe can report: the glibc version needed and the one the host has, or that the host has no |
||
| > **Tech Preview:** This software is provided as-is, without warranty or | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph correctly retires the old "every published build of it needs those versions" framing (2026.45.3 needs more), and the refusal-describing sentence later on is correctly scoped to glibc/libssl.so.3 only. But the identical old framing — "every published Lemonade embeddable requires/is linked against glibc 2.38 (and
GLIBCXX_3.4.32)" — is left unedited in several other places this PR doesn't touch, two of which are strings printed directly to users:docs/wsl.md:18-20crates/rocm-core/src/fix/catalog.rs'sfix-wsl-5-distro-too-oldrationale(printed byrocm fix)crates/rocm-core/src/diagnose/wsl.rs's matchingnotes(printed byrocm diagnose)crates/rocm-core/src/examine.rs'sWSL_MIN_UBUNTUdoc comment (says "Seedocs/wsl.md")skills/rocm-doctor/reference.md:188AGENTS.md §5 names exactly this failure mode: a behavior claim repeating across docs and printed CLI output, each drifting independently. Since this PR is what invalidates the "every published build" framing (by introducing 2026.45.3 as the counter-example), the sibling surfaces should get the same "2026.44.1 needs this; the newest release needs more" nuance.
Confidence 90 · mechanical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 3779afb. Four of the five places now name the pinned build instead of "every published" one, and add that newer Lemonade releases need more:
docs/wsl.mdfix-wsl-5-distro-too-oldrationalerocm fixprints (fix/catalog.rs)rocm diagnoseprints (diagnose/wsl.rs)WSL_MIN_UBUNTU's doc comment (examine.rs)The printed strings do not name a version, so they stay true across bumps. No test pins that text, and
cargo xtask catalog --checkpasses (the generated catalog does not carry it).I left
skills/rocm-doctor/reference.mdalone. Its row says "the 2.38 /GLIBCXX_3.4.32the engines need", which is true of the pinned build and does not make the "every published" claim. It is also a parsed e2e fixture.On GLIBCXX (from the review body): the README now says that the check reads glibc and OpenSSL only, and that
GLIBCXX_3.4.32(libstdc++) is not checked.