Repository navigation
ROCMAI-791: add rocm logs --follow to watch a starting server #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a789a8a
ROCMAI-791: add rocm logs --follow to watch a starting server's output
juhovainio 82d482a
ROCMAI-791: add rocm serve --wait to wait out a first-time model down…
juhovainio 2f6d0b5
ROCMAI-791: end serve --wait when the server dies; harden --follow ou…
juhovainio b9deedf
ROCMAI-791: test the serve --wait server-died path; keep a failed state
juhovainio 8fedcfa
ROCMAI-791: fix CI: const fn on non-Linux zombie probe, feature-quali…
juhovainio d0062bf
ROCMAI-791: keep the --follow hint under the newest log line on a ter…
juhovainio 567774f
ROCMAI-791: merge main; renumber the --wait scenario to serve-42, res…
juhovainio 486dcc3
ROCMAI-791: order serve-42 after serve-41 so scenario names stay sequ…
juhovainio f14f485
ROCMAI-791: wait on an already-starting server, tighten follow output
juhovainio 125ba11
ROCMAI-791: name the real service id in the --wait banner; strip esca…
juhovainio d05bc07
ROCMAI-791: say --wait ends when the engine gives up, not only when t…
juhovainio 2aeeea4
ROCMAI-791: follow/wait review items: key before wait, fresh record w…
juhovainio 84b539f
ROCMAI-791: keep the dummy api key out of wait-begin test failure mes…
juhovainio 0476f4d
Merge remote-tracking branch 'origin/main' into fix-857
juhovainio 58c683f
Merge remote-tracking branch 'origin/main' into fix-857
juhovainio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: with
--allow-public-bind/--require-api-keythe generated key is printed ("shown only now") only afterstart_managed_servicereturns. Now that the wait is unbounded, Ctrl-C (which the banner invites) or a failed wait leaves a running authenticated server whose key was never shown, and no command prints it. Printing the client config before the wait (e.g. from this callback) would avoid that.