Repository navigation
ROCMAI-834: remove the unused dash-tui skills subsystem and its list_skills and skill_plan agent tools #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jussielo-amd
merged 4 commits into
ROCm:main
from
jussielo-amd:refactor-dash-tui-remove-skills
Nov 5, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
323c662
refactor(dash-tui): stop advertising the list_skills and skill_plan a…
jussielo-amd eb71525
refactor(dash-tui): remove the unused skills module
jussielo-amd 196047d
docs: drop stale references to the removed skills module and `rocm sk…
jussielo-amd b61f9b7
refactor(dash-tui): assert the exact tool set sent to the model
jussielo-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking:
SKILL_NAMES(and its doc comment above, "All Skill names") now holds only the four telemetry tools, so the name is misleading with the skills subsystem gone. ConsiderTELEMETRY_TOOL_NAMESin a follow-up;docs/architecture.mdalso still refers to "Skill" wrappers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, the name no longer fits now that the skills subsystem is gone. I kept this PR to the removal and filed the rename plus the remaining "Skill" wording in the docs and comments as ROCMAI-864, so it can go in as one focused change.
On dropping
retired_skill_registry_tools_are_not_advertised: I would keep it for now. The wire-level assertion compares what the model receives against the name tables, so if someone re-registered a retired tool and added its name toSKILL_NAMESin the same change, the exact-set check would still pass. The unit test pins the retired names out of the tables themselves. I am happy to fold it into the exact-set check as part of the rename if you would rather have a single assertion.