Repository navigation
ci: skip the E2E scenarios when clippy is not green #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9798dcc
ci: skip the E2E scenarios when clippy is not green
jussielo-amd 5ea5f28
ci: note why the E2E gate requires clippy to succeed, not skip
jussielo-amd 111bf78
test(xtask): name the E2E gate outcome and share its assertions
jussielo-amd b6b7829
ci: do not claim the clippy skip blocks the merge in the E2E notice
jussielo-amd 20858e3
test(xtask): drive the E2E gate order test through run_e2e_gate
jussielo-amd 8300dc9
ci: wrap the E2E gate comment and tell the notice to re-run the workflow
jussielo-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the sibling gate at ~L1129 accepts
success || skippedfor clippy, while this one requiressuccess. The rationale is in the comment above, but a one-line pointer here saying the difference is deliberate would stop a future reader from "aligning" them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a one-line comment at the new gate saying the difference is deliberate (5ea5f28):
clippyhasif: github.event_name != 'workflow_dispatch', so it is skipped only on a dispatch, which the gate's first branch handles, and a skip anywhere else must not open the gate.