Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
46f99c9
test(engine-ipc): pin what rocm and rocmd each send an engine child a…
jussielo-amd Nov 5, 2026
b8535d5
refactor(engine-ipc): run engine children through one stdio client sh…
jussielo-amd Nov 5, 2026
d2ac4eb
fix(rocmd): reach engines through the rocm executable when running as…
jussielo-amd Nov 5, 2026
8d58bf0
fix(engine-protocol): guard the stderr forwarding writes against SIGPIPE
jussielo-amd Nov 6, 2026
52ef4ee
fix(engine-protocol): quote what the fake engine puts in shell literals
jussielo-amd Nov 6, 2026
1f7804b
fix(engine-protocol): kill and reap the engine child when its answer …
jussielo-amd Nov 6, 2026
40942ff
test(core): enter the two overlapping SIGPIPE guards in a fixed order
jussielo-amd Nov 6, 2026
06371bb
test(e2e): drive the daemon's stop tool against an engine that exits …
jussielo-amd Nov 9, 2026
dfe8c05
Merge main into split-engine-ipc-client
jussielo-amd Nov 9, 2026
b648ab7
fix(rocmd): recognise the standalone daemon after its executable was …
jussielo-amd Nov 9, 2026
3e292d6
fix(engine-protocol): name the exit status when a failing child's ans…
jussielo-amd Nov 9, 2026
87c0d2f
fix(engine-protocol): report what an engine said on stderr when its r…
jussielo-amd Nov 9, 2026
ace9d9f
docs(engine-protocol): state that waiting for a child's pipes after i…
jussielo-amd Nov 9, 2026
9d46e16
test(engine-protocol): pin that stderr forwarding guards each write a…
jussielo-amd Nov 9, 2026
f21b620
Merge main into split-engine-ipc-client
jussielo-amd Nov 9, 2026
c9e7b98
style(engine-protocol): build the error messages without appending a …
jussielo-amd Nov 9, 2026
ef4db55
Merge main into split-engine-ipc-client
jussielo-amd Nov 9, 2026
30504f1
fix(engine-protocol): stop collecting a failed write's stderr at the …
jussielo-amd Nov 9, 2026
f150318
test(engine-protocol): show that forward_stderr sends the child's std…
jussielo-amd Nov 9, 2026
a44f2d3
fix(engine-protocol): word a failing exit from its code or signal, no…
jussielo-amd Nov 9, 2026
bef1469
docs(engine-protocol): state the stalled-sink SIGPIPE limit, and narr…
jussielo-amd Nov 9, 2026
838d909
style(engine-protocol): inline the format argument in the forwarding …
jussielo-amd Nov 9, 2026
8486362
fix(rocmd): recognise the standalone daemon by its whole file name
jussielo-amd Nov 9, 2026
e399137
test(rocm): compare a child's inherited environment with the ambient …
jussielo-amd Nov 9, 2026
6785a7c
test(engine-protocol): cover the stdio client's remaining branches so…
jussielo-amd Nov 9, 2026
80db099
docs(engine-protocol): state that an answer printed before a failed r…
jussielo-amd Nov 9, 2026
2dd24d1
style(rocm): drop a redundant clone in the environment test
jussielo-amd Nov 9, 2026
52b0103
Merge main into split-engine-ipc-client
jussielo-amd Nov 9, 2026
042f8cc
docs(core): say what the SIGPIPE guard's restore can and cannot round…
jussielo-amd Nov 9, 2026
813357a
refactor(core): name the three ROCM_CLI_*_DIR variables once
jussielo-amd Nov 9, 2026
d28902e
test(e2e): assert service-stop-02's whole engine answer and fix the s…
jussielo-amd Nov 9, 2026
afd6d79
docs(engine-protocol): name the ok:true case of an answer followed by…
jussielo-amd Nov 9, 2026
95f8c24
test(xtask): fail when a second engine stdio client appears
jussielo-amd Nov 9, 2026
f07a6b5
fix(engine-protocol): read the child's stderr from the start so a ful…
jussielo-amd Nov 9, 2026
a1b005a
refactor(rocm): call AppPaths::env_vars directly and fix the engine p…
jussielo-amd Nov 9, 2026
ad70a49
Merge main into split-engine-ipc-client
jussielo-amd Nov 9, 2026
1613003
fix(engine-protocol): publish stderr as it arrives and stop retaining…
jussielo-amd Nov 9, 2026
d1dac08
Merge origin/main into split-engine-ipc-client
jussielo-amd Nov 10, 2026
bb914a7
fix(engine-protocol): report stderr when the answer cannot be read, k…
jussielo-amd Nov 10, 2026
5ad422f
fix(rocm): keep the Windows-only engine_runtime_select imports when d…
jussielo-amd Nov 10, 2026
94cde4b
fix(engine-protocol): write the failing-exit note through the SIGPIPE…
jussielo-amd Nov 10, 2026
6d83971
fix(engine-protocol): forward only complete UTF-8 so a split characte…
jussielo-amd Nov 10, 2026
6b9a6f9
fix(engine-protocol): keep the replacement character out of a product…
jussielo-amd Nov 10, 2026
6732ccf
Merge origin/main into split-engine-ipc-client
jussielo-amd Nov 10, 2026
60cb59e
fix(rocm-core): drop the duplicated test attribute left by the main m…
jussielo-amd Nov 10, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions apps/rocm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ apple-native-keyring-store = { version = "1.0", features = ["keychain"] }
zbus-secret-service-keyring-store = { version = "1.0", features = ["rt-tokio-crypto-rust"] }

[dev-dependencies]
# The fake engine child both engine IPC callers are tested against.
rocm-engine-protocol = { path = "../../crates/rocm-engine-protocol", features = ["test-support"] }
# Property-based tests for the byte-size formatter behind the `download:
# approved up to …` line. "A size is printed in its own unit" has to hold at
# every unit boundary, and the narrow band where `{:.1}` rounding reaches 1024.0
Expand Down
3 changes: 1 addition & 2 deletions apps/rocm/src/chat/mcp_bridge.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

use super::summaries::managed_service_running_state;
use crate::automations::{render_automations_text, render_daemon_text};
use crate::engine_runtime_select::app_path_env_vars;
use crate::freeform_planner::{format_structured_tool_call, plan_freeform_request_with_context};
use crate::managed_service_status::{load_managed_services, managed_service_is_live};
use crate::rocm_argv::{chat_cli_arg_value, chat_cli_has_flag};
Expand Down Expand Up @@ -458,7 +457,7 @@ fn run_rocm_capture_for_paths(
args: &[&str],
timeout: Duration,
) -> Result<CommandCapture> {
rocm_core::run_rocm_capture_with_env(args, &app_path_env_vars(paths), timeout)
rocm_core::run_rocm_capture_with_env(args, &paths.env_vars(), timeout)
}

fn run_rocm_command_for_paths(
Expand Down
Loading
Loading