Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/rocm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ e2e-test-hooks = [
# hook that simulates a managed vLLM launch which OOM'd and never became ready,
# so the positive OOM-guidance summary can be verified on a GPU-less CI host.
# See `e2e_simulate_oom_launch` / `simulate_oom_managed_launch` in
# `service_launch.rs`.
# `service_launch/readiness.rs`.
e2e-oom-fault-injection = []

[dependencies]
Expand Down
2 changes: 1 addition & 1 deletion apps/rocm/src/endpoint_keys.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
//! Secure storage for per-service inference-endpoint API keys.
//!
//! When `rocm serve` binds a public (non-loopback) interface it protects the
//! endpoint with an API key (see `resolve_endpoint_auth` in `service_launch.rs`).
//! endpoint with an API key (see `resolve_endpoint_auth` in `service_launch/endpoint_auth.rs`).
//! The key is stored in a 0600 file under the services directory, keyed by
//! service id.
//!
Expand Down
3 changes: 2 additions & 1 deletion apps/rocm/src/serve_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1290,7 +1290,8 @@ pub(crate) fn serve(args: ServeArgs) -> Result<()> {
notes,
};
// Same intentional one-time key display as `print_managed_launch_plain`
// in service_launch.rs; see its rationale for why the tag below is currently inert.
// in service_launch/start.rs; see its rationale for why the tag below is
// currently inert.
// codeql[rust/cleartext-logging]
print!("{}", serve_summary::render_summary(&summary));
} else {
Expand Down
6 changes: 3 additions & 3 deletions apps/rocm/src/serve_port.rs
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,9 @@ pub(crate) fn resolve_serve_port(
if let Some(owner) = reserved.iter().find(|entry| entry.port == port) {
// The "stop it" advice below is proven, not just worded: see
// `stopping_the_reserving_record_frees_its_explicit_port_for_reuse`
// in `service_launch.rs`, which recreates the exact on-disk status
// transition `rocm services stop` performs and confirms the same
// explicit port then resolves. A full CLI-level E2E for this needs
// in `service_launch/launch_transaction.rs`, which recreates the exact
// on-disk status transition `rocm services stop` performs and confirms
// the same explicit port then resolves. A full CLI-level E2E for this needs
// a real GPU, since reaching this branch requires a completed
// model/engine resolution first.
bail!("{}", reserved_message(DEFAULT_LOCAL_HOST, port, owner));
Expand Down
4,947 changes: 46 additions & 4,901 deletions apps/rocm/src/service_launch.rs

Large diffs are not rendered by default.

Loading
Loading