Repository navigation
refactor(rocm-core): one kernel-release read for the summary and the examination stacks #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jussielo-amd
merged 17 commits into
main
from
refactor-one-kernel-release-read-for-host-probing
Nov 10, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1868023
test(rocm-core): pin both kernel-release reads' answers before they a…
jussielo-amd ba7e0f9
refactor(rocm-core): one kernel-release read for the summary and the …
jussielo-amd ec0388e
test(e2e): hold summary.kernel and kernel_release level in one examin…
jussielo-amd 1ecdb96
docs: record the kernel-release decisions in the host-probing note
jussielo-amd ec8ff1e
test(rocm-core): make the hung-uname test fail when the timeout is re…
jussielo-amd d128fc1
refactor(rocm-core): read the kernel release once for rocm examine --…
jussielo-amd cb77d8a
test(rocm-core): gate the kernel-release tests on Linux and say what …
jussielo-amd 3134ab9
refactor(rocm-core): write the kernel-release timeout out as five sec…
jussielo-amd 8d725dc
test(e2e): quote the stand-in uname's log path for the shell
jussielo-amd 1ba3936
Merge remote-tracking branch 'origin/main' into rf-923a
jussielo-amd 1c3e4c2
test(e2e): do not use rocm-core from the harness library's non-test code
jussielo-amd d0367b6
test(rocm-core): answer the slow-uname test after 2 s instead of 3 s
jussielo-amd 8b58e7d
docs: say the examination handed to gather_after must be from this ho…
jussielo-amd c9c8258
test: assert no probe_failures entry for a failed kernel read, whatev…
jussielo-amd 4877662
refactor(rocm-core): pair the examination and the summary inside rocm…
jussielo-amd a20843d
Merge origin/main into refactor-one-kernel-release-read-for-host-probing
jussielo-amd ade7224
test(e2e): number the kernel-release scenarios examine-43 and examine-44
jussielo-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right: the
--jsonhandler built the examination and then the summary, each starting its ownuname -r, so a transient failure could split the two fields and a hungunamecost two timeouts. I took the preferred fix in d128fc1:ExamineSummary::gather_aftertakes the examination'skernel_release, a failed read included, on Linux instead of runninguname -ragain, androcm examine --jsonuses it. Callers that gather only the summary (the text form, the MCP and bridge snapshots) still read once for themselves, and off Linux the summary reads for itself, because the examination does not read the kernel on Windows. It is tested by counting reads:the_summary_reads_the_kernel_only_when_the_examination_did_notcounts the read function per case (none when the examination has a value, none for an empty one, one otherwise), and scenarioexamine-39now logs the calls of its stand-inunameand expects exactly one-r, which fails with two when the handler is put back ongather(I ran that mutation through the real harness). The note and the architecture entry say one read per run where that holds, and "one reader" for the rest.