Repository navigation
refactor(rocm-core): one CPU model-and-vendor read for the summary and the examination stacks #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jussielo-amd
merged 8 commits into
main
from
refactor-one-cpu-model-and-vendor-read-for-host-probing
Nov 10, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dbaf524
test(rocm-core): take the host-root lock in the two repo-scan tests t…
jussielo-amd 1da6845
test(rocm-core): pin both CPU-model reads' answers before they are me…
jussielo-amd 1c9f21b
refactor(rocm-core): one CPU model and vendor reader for the summary …
jussielo-amd d4b3838
test(e2e): hold summary.cpu and cpu_model level in one examine run
jussielo-amd 66c80ff
docs: record the CPU-model decisions in the host-probing note
jussielo-amd aac07b4
refactor(rocm-core): name the inventory query in the Windows CPU fail…
jussielo-amd 27a5d64
refactor(rocm-core): make detect_cpu_model Linux-only so it cannot st…
jussielo-amd e480a32
Merge origin/main into refactor-one-cpu-model-and-vendor-read-for-hos…
jussielo-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPU and RAM now disagree about what an absent inventory means.
summary_cpuhere drops the CPU's second query on the reasoning that no inventory implies the system query already failed, so asking again just repeats a failed query. Butdetect_system_ram_gib_with_windows_inventoryimmediately below (roughly lines 294-305) still falls back to its own query for the RAM row — the same row set, from the same query. If a repeat is pointless for the CPU it should be pointless for the RAM, and if it isn't pointless the CPU shouldn't have dropped it.The RAM fallback predates this PR, so this isn't a regression you caused — it just became inconsistent here. A sentence in the note saying why RAM keeps its fallback (or a follow-up to drop it) would close the gap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the RAM fallback and said why in docs/host-probing.md. The reason is not that a repeat is useful for RAM: detect_system_ram_gib is a public reader that model_fit calls with no inventory at all, so its Windows query has to exist, and removing the summary's fallback would change what the summary shows for RAM when the inventory is absent, a behaviour change for a fact this PR does not touch and would want its own test. So the two disagree on purpose, for now, and dropping the RAM fallback to follow the CPU is recorded as a follow-up in the note and the PR text.