Repository navigation
Merge dev into main for NICHESv2 1.0.0 - #94
Merged
Merged
Conversation
Eliminate warning and notes.
Warning and Note Elimination
Create the R-CMD-check.yaml file for CI
1. Update README with the smallest bundle of test data; 2. Initiate the R-CMD-check.
Update README and Start R-CMD-check
Add "Windows" to the systems parallelization applies
Started working on Vignettes. Part 1 - getting started briefly done. Working on next two.
Vignette 1
Add 3 vignettes, 1 rendered and 2 pre-rendered.
Adding Vignettes
pakagedown update
Start aggregation design - cell centric
Aggregation functions
Aggregation simplification
Change default LRM database to ConnectomeDB2025, with 4 species provided, human, rat, mice, pig. Modified the aggregation related functions too.
Default LRM database change
1. Added a fifth category for autocrine edges splitting - self autocrine (center cell) or other autocrine (other cells in the neighborhood but not the center cell itself) 2. Updated the descriptive files.
Distinguish between self.autocrine and other.autocrine
housekeeping - removing OBS files
- CLAUDE.md documents package architecture, development commands, and non-obvious design decisions (S3 copy semantics, long-format storage, aggregation framework, parallelism rules, known issues) - demo-scripts/run_NICHESv2_Xenium_PPLR.R: spatial NICHESv2 run on Rat-PPLR-Run1 Xenium data (rad=25, Type.6, sample.col=TMA) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add CLAUDE.md and Xenium PPLR demo script
Exports a NICHESObject to the 16-column edges.parquet schema expected by TissuePlex. Joins edge.data (sparse LRM scores) with edge.meta (coordinates, cell types), derives is_autocrine and lrm_id, splits LRM strings into ligand/receptor, and writes via arrow::write_parquet. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
export to tissueplex addition
Fixing the aggregation function
Improved the aggregation efficiency - used matrix temporarily to create neighborhood.edge.agg slot. Also to reduce memory use, applied chunked sparse matrix approach.
Improved the efficiency of aggregation
Update the design files
Delete them because Sam's TissuePlex can do this very well, in an interactive mode like Xenium Explorer.
deleted the CellToCell_InSitu plot functions
Create TEST.txt
This option is not mathematically solid and will need much effort to implement, without certain improvement, and will cause confusion to potential users. So we decided to delete it.
deleted "smooth" option
Fix OmniPath loading resilience (port NICHESv1 PR #72 / issue #70) Newer OmnipathR (>= ~3.17, incl. 4.1.0) resolves the `organism` argument through ncbi_taxid(), which downloads and coalesces species tables from Ensembl, OMA, and UniProt. When any of those ancillary services is unreachable (e.g. omabrowser.org returning HTTP 502), the call aborts with "Can't combine `..1` and `..3`" even though the OmniPath interaction server itself is fine. load_LRM_database("omnipath") now delegates to a resilient fetcher that: 1. tries the standard OmnipathR path with its console logging muted, 2. falls back to a direct OmniPath REST query using the known NCBI taxon id, bypassing the failing organism-name lookup, and 3. raises an informative network error only if both paths fail. The fallback is base-R only (utils::download.file / read.delim) and adds no new dependencies. Ported from NICHESv1.
Fix Omnipath issue
Subsetting left the neighborhood slots at full-object size, so aggregating a subset could give wrong means. Retained cells now keep their neighborhood entries and aggregation rows unchanged. Recomputing on a subset stops with an error unless add_neighborhoods(overwrite = TRUE) is run first. Other changes: - Bump version to 1.0.0; update DESCRIPTION and license files for CRAN - Remove setDTthreads(0L) on load, which reset worker threads - Clear the correct edge aggregation in add_neighborhoods(overwrite = TRUE) - Restore the caller's random state in seeded functions - Replace \dontrun examples and add a small example .h5ad - Correct help pages and message wording; use US spelling in docs - Add R-devel and PDF manual checks to the GitHub workflow
Fix neighborhood slots when subsetting NICHESObject
Replace unsupported characters that stopped the PDF manual, and finish US spelling in R/. Replace the three old vignettes with one that runs on bundled data, and remove prettydoc. Rewrite README and NEWS, and update CLAUDE.md and the design document. Update the GitHub workflow: remove the separate Bioconductor install step, and add tidy and V8 to the Ubuntu release job.
Fix PDF manual and replace vignettes for 1.0.0
Add website publishing workflow and links
Add website publishing workflow and links
ix SeuratData install in website workflow
Fix SeuratData install in website workflow
Change license from MIT to GNU AGPL v3
Change license from MIT to GNU AGPL v3
Point README badge to main
Point README badge to main
Stop tracking local settings and OmniPath logs
Stop tracking local settings and OmniPath logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge dev into main for NICHESv2 1.0.0