01a000c3 - Cancel pending RealUnit buy quotes - #916
Open
TaprootFreak wants to merge 30 commits into
Open
Conversation
Add PUT /v1/realunit/buy/:id/deactivate from the pending list and the confirm screen. Waiting quotes are identified by uid when id is null.
Guard the cubit while loading, disable the cancel button, and ignore a second pending-row tap until the first deactivate finishes. Cover GoRouter pop after a successful cancel.
The confirm/deactivate column uses 8px spacing. Cancel is offered only on buys that have an id or uid. A failed pending-list reload no longer wipes a list that was already on screen. The buy responsive matrix now covers the two-button success state.
After a successful deactivate the row is removed before reload. A second deactivate is ignored while one is in flight. The confirm dialog checks mounted, and each pending row has a ValueKey.
Processing buys no longer show deactivate. Concurrent cancels of different quotes still run; a second tap on the same quote is ignored.
Deactivate uses its own loading state so confirm and cancel do not share a spinner. The pending list drops a cancelled quote by id or uid and does not emit after the cubit is closed.
Guard BuyConfirmCubit.deactivateQuote emits with isClosed. Empty id/uid cancel tests now use WaitingForPayment so they hit the idOrUid check.
Non-200 pending fetches throw so a failed refresh cannot wipe quotes. Overlapping reloads use a generation counter so an older GET cannot restore a cancelled row.
TaprootFreak
marked this pull request as ready for review
August 14, 2026 20:57
TaprootFreak
marked this pull request as draft
August 14, 2026 21:04
TaprootFreak
marked this pull request as ready for review
August 14, 2026 21:35
Contributor
Author
|
EN: DE: DetailsHead Comment 5298573406 was the previous ready note (confirm-screen cancel). This patch is the single Abschluss for the PR. Review loop: coverage hole on the unused wrapper constructor, then confirm-as-sheet / type-neutral title / back-during-loading, then overflow at 3.0x text scale, then the sticky-CTA catalog+matrix for the sheet. Last dual review: 0 findings. CI on this head: Analyze & Test, Coverage Floor Gate, Visual Regression, BitBox quirks audit, Handbook Build Check all SUCCESS. Maestro handbook flows SKIPPED (no Touched UI files 100% line coverage on the full lcov (Analyze & Test). Handbook cards 270–272, count pin 282. Goldens regenerated on the self-hosted runner; last dispatch reported no further pixel change. |
TaprootFreak
marked this pull request as draft
August 17, 2026 06:56
Remove cancel from the buy-confirm screen. A pending dashboard row opens a detail page where waiting buy quotes can be cancelled. CONTRIBUTING now requires 100% line coverage on every UI file a PR touches.
The Alchemist overlay navigator does not inherit S, so S.of(dialogContext) threw when capturing the confirm dialog golden.
Alchemist does not capture a showDialog overlay, so the previous tap golden was identical to the detail page. Extract CancelQuoteConfirmDialog and snapshot it directly.
Restore the dashboard page constructor, remove unused list-cubit deactivate, and pop the cancelled id so a failed reload cannot restore the row.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 08:11
TaprootFreak
marked this pull request as draft
August 17, 2026 08:12
Three new pending-transaction-detail cards landed in the assemble map; the Handbook Build Check still expected 279.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 08:20
TaprootFreak
marked this pull request as draft
August 17, 2026 08:23
The GetIt wiring test must construct BuyConfirmButton non-const so the constructor lines stay covered; analyzer treated that as info.
Update the leftover 279 comment and include slots 270 and 272 so the handbook container check covers the new pending-detail goldens.
Add PendingTransactionDetailPage to the screen table with handbook slots 270-272 and bump the routed-screen count.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 08:41
TaprootFreak
marked this pull request as draft
August 17, 2026 08:59
A depth-1 fetch of the PR base SHA left no merge-base, so git diff BASE...HEAD exited 128 on Analyze & Test.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 09:08
TaprootFreak
marked this pull request as draft
August 17, 2026 09:34
The touched-UI gate reported 29/30 on the pending-list view; add the back-without-cancel and dispose-during-push cases.
Keep the navigator alive, hide the pending list, then pop so the mounted guard actually runs.
The pending cubit lives on DashboardPage and outlives the zero- vs nonzero-balance list view. Bind drop/reload to cubit.isClosed, not widget mounted, and assert the success pop payload.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 09:56
TaprootFreak
marked this pull request as draft
August 17, 2026 10:21
Flip the cubit-closed flag only after navigation so the early return on a closed pending cubit is actually executed.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 10:28
TaprootFreak
marked this pull request as draft
August 17, 2026 10:47
Move drop/reload/isClosed out of the list view so the touched-UI coverage gate no longer depends on an unmounted-widget branch.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 10:55
TaprootFreak
marked this pull request as draft
August 17, 2026 11:17
The unused DashboardPendingTransactions widget created a second cubit and left its const constructor at 0 hits in the full-suite lcov.
Cancel confirmation uses the same bottom-sheet pattern as the rest of the app. The detail title is type-neutral, and the back gesture is blocked while deactivate is in flight.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 12:12
TaprootFreak
marked this pull request as draft
August 17, 2026 12:41
The confirm sheet now uses ScrollableActionsLayout so it does not overflow on small devices at 3.0x text scale.
Catalog the confirm sheet as its own sticky-CTA surface and open it through a real modal so both buttons stay tappable at 3.0x text scale.
TaprootFreak
marked this pull request as ready for review
August 17, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Customers can cancel a pending RealUnit buy quote only after the binding purchase. On the dashboard they tap a pending transaction, see its details, and choose Cancel quote when it is a buy still waiting for payment. The buy-confirm screen no longer offers cancel. CONTRIBUTING now requires 100% line coverage on every UI file a PR touches.
DE:
Kunden können ein RealUnit-Kaufangebot erst nach dem verbindlichen Kauf stornieren. Auf dem Dashboard tippen sie eine ausstehende Transaktion an, sehen die Details und wählen Angebot stornieren, wenn es ein Kauf im Status Warte auf Zahlung ist. Der Bestätigungsbildschirm vor dem verbindlichen Kauf hat keinen Storno mehr. CONTRIBUTING verlangt 100 % Line-Coverage für jede von einem PR berührte UI-Datei.
Details
Depends on DFXswiss/api#4982 (
PUT /v1/realunit/buy/:id/deactivate).BuyConfirmButtonis confirm-only/dashboard/pendingTransactiontype == buyandstate == waitingForPaymentscripts/check-touched-ui-coverage.shon the full lcov before the packages/cubits/blocs extractGoldens for the new detail screens and the updated buy-confirm / dashboard pending shots are regenerated on the self-hosted runner.