Skip to content

01a01ecf - Stage the fourteen account-merge web baselines (22 → 36) - #920

Merged
TaprootFreak merged 1 commit into
stagingfrom
fix/handbook-web-baselines-36
Aug 20, 2026
Merged

01a01ecf - Stage the fourteen account-merge web baselines (22 → 36)#920
TaprootFreak merged 1 commit into
stagingfrom
fix/handbook-web-baselines-36

Conversation

@TaprootFreak

Copy link
Copy Markdown
Contributor

EN:
The handbook production deploy failed because the web-baseline guard still expected 22 Playwright PNGs after RealUnitCH/web added 14 for /account-merge/.
This change raises EXPECTED_WEB_BASELINE_COUNT to 36 and adds matching cards in #spec-web.
The cards describe adding a wallet address, not merging two accounts.
After this lands on staging, the staging-to-develop promotion can run that deploy again.

DE:
Der Handbook-Produktions-Deploy ist fehlgeschlagen, weil der Web-Baseline-Guard noch 22 Playwright-PNGs erwartet hat, nachdem RealUnitCH/web 14 für /account-merge/ ergänzt hat.
Diese Änderung setzt EXPECTED_WEB_BASELINE_COUNT auf 36 und ergänzt die passenden Karten in #spec-web.
Die Karten beschreiben das Hinzufügen einer Wallet-Adresse, nicht das Zusammenführen zweier Konten.
Sobald das auf staging liegt, kann der Promote staging→develop den Deploy erneut fahren.

Details

The auto-promotion PR #904 (Promote: staging -> develop) is red on deploy-prd / Build and deploy to PRD only:

Expected exactly 22 web baseline PNGs in _web-checkout/tests/__screenshots__, got 36.

Analyze & Test, Visual Regression, Coverage Floor Gate, and the PR-only Handbook Build Check stayed green: that last job does not clone RealUnitCH/web, so it never sees the count.

Cause: RealUnitCH/web#25 committed 14 new Playwright baselines for /account-merge/ (add a wallet address to an existing account). The previous handbook update of this guard was #862 (18 → 22, no-registration confirm states). There was no open PR covering 22 → 36.

New files (14):

Viewport Files
desktop-chromium merge-confirmed(.png + -en.png), merge-invalid(.png + -en.png), merge-already-completed(.png + -en.png), merge-unavailable(.png + -en.png)
tablet-chromium merge-confirmed.png, merge-invalid.png (no tablet shots exist for already-completed / unavailable)
mobile-safari merge-confirmed-mobile.png, merge-invalid.png, merge-already-completed.png, merge-unavailable.png

Same markup as the existing confirm cards in #spec-web. Intro and docs/handbook/README.md now name /account-merge/ next to /confirm-aktionariat.

No Dart, no golden regeneration, no other workflow files.

RealUnitCH/web added 14 Playwright baselines for /account-merge/.
The handbook deploy-prd guard still expected 22, so the staging-to-develop
promotion failed. Bump EXPECTED_WEB_BASELINE_COUNT and add matching
#spec-web cards for the add-address flow.
@TaprootFreak
TaprootFreak marked this pull request as ready for review August 20, 2026 11:19
@TaprootFreak

Copy link
Copy Markdown
Contributor Author

EN:
Ready after 1 review pass.
The handbook web-baseline guard and #spec-web cards now cover all 36 Playwright PNGs from RealUnitCH/web, including the fourteen /account-merge/ add-address screenshots.

DE:
Bereit nach 1 Review-Durchlauf.
Der Handbook-Web-Baseline-Guard und die #spec-web-Karten decken jetzt alle 36 Playwright-PNGs aus RealUnitCH/web ab, inklusive der vierzehn /account-merge/-Screenshots zum Hinzufügen einer Adresse.

Details

Review: one pass, 0 findings (quality and logic).

Comments: 0 issue comments, 0 reviews, 0 inline comments, 0 review threads.

Mergeable: MERGEABLE against staging at 842777ae. mergeStateStatus=BLOCKED is the missing human approval, not a conflict.

CI at 842777ae (non-draft run):

Check Result
Analyze & Test success (22m45s)
Visual Regression success
Coverage Floor Gate success
BitBox quirks audit success
Build handbook image + container smoke success
Maestro handbook flows skipped — no tier3:full label (documented condition)

Required on staging: Analyze & Test, Visual Regression, Coverage Floor Gate — all success on this head.

This PR does not itself re-run deploy-prd on #904. That job runs on push to staging. After this merges, the auto-promotion PR should pick up the 36-count guard.

@TaprootFreak
TaprootFreak merged commit e7bcb6a into staging Aug 20, 2026
12 checks passed
@TaprootFreak
TaprootFreak deleted the fix/handbook-web-baselines-36 branch August 20, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant