Repository navigation
fix(auth): upgrade explicit legacy sessions - #1756
Merged
Baskarayelu merged 2 commits intoOct 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1745
migrateV1ToV2previously only setschemaVersionwhen the existing value was not a number. An explicitschemaVersion: 1was therefore left unchanged, even though the result was typed asSessionDataV2.This change upgrades unversioned, V0, and explicit V1 sessions to V2; rejects invalid shapes and unsupported future versions with a discriminated result; validates Stellar addresses and timestamp ranges; and records migration attempts and failures. Unknown fields are preserved during upgrades.
The result type now distinguishes success from failure:
Tests were updated to import the module by relative path, cover explicit V0/V1 and future versions, invalid addresses and timestamps, stats, and generated idempotency cases. Fixtures with equal timestamps are now expected to be invalid because
expiresAtmust be greater thancreatedAt.